summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAntony Pavlov <antonynpavlov@gmail.com>2011-09-12 14:25:46 +0400
committerSascha Hauer <s.hauer@pengutronix.de>2011-09-13 09:29:34 +0200
commita8af2ad4f1de08166ab581f4c0a3dc2c29a3d844 (patch)
tree3335ffe0631b905fadae760a32f8422e9484aea5
parent3c68ddb583b4651d14758841f23d4cdcf4873285 (diff)
downloadbarebox-a8af2ad4f1de08166ab581f4c0a3dc2c29a3d844.tar.gz
barebox-a8af2ad4f1de08166ab581f4c0a3dc2c29a3d844.tar.xz
usb.c: warning on USB_MAXINTERFACES overflow
Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
-rw-r--r--drivers/usb/core/usb.c10
1 files changed, 10 insertions, 0 deletions
diff --git a/drivers/usb/core/usb.c b/drivers/usb/core/usb.c
index b01a79745e..5dc8afee00 100644
--- a/drivers/usb/core/usb.c
+++ b/drivers/usb/core/usb.c
@@ -207,6 +207,16 @@ static int usb_parse_config(struct usb_device *dev, unsigned char *buffer, int c
&buffer[index])->bInterfaceNumber != curr_if_num) {
/* this is a new interface, copy new desc */
ifno = dev->config.no_of_if;
+ /* if ifno > USB_MAXINTERFACES, then
+ * next memcpy() will corrupt dev->config
+ */
+ if (ifno > USB_MAXINTERFACES) {
+ printf("ifno = %d > "
+ "USB_MAXINTERFACES = %d !\n",
+ ifno,
+ USB_MAXINTERFACES);
+ break;
+ }
dev->config.no_of_if++;
memcpy(&dev->config.if_desc[ifno],
&buffer[index], buffer[index]);