summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSascha Hauer <s.hauer@pengutronix.de>2012-12-07 16:43:15 +0100
committerSascha Hauer <s.hauer@pengutronix.de>2012-12-07 16:43:15 +0100
commitdf1d2a725755dbe78b2a9c8ab924a9ff238e9a04 (patch)
treeb764d5b01ba06b81221d1a0aba465e1924ea5151
parent86ee7f112f34e827abb9edcf41bc9e5f188bf646 (diff)
parent3139c3e9a61e70846be8c4f95bb9cffd4465d88a (diff)
downloadbarebox-df1d2a725755dbe78b2a9c8ab924a9ff238e9a04.tar.gz
barebox-df1d2a725755dbe78b2a9c8ab924a9ff238e9a04.tar.xz
Merge branch 'for-next/mtd'
-rw-r--r--drivers/mtd/core.c56
-rw-r--r--drivers/mtd/mtdoob.c3
-rw-r--r--drivers/mtd/nand/nand_write.c7
3 files changed, 6 insertions, 60 deletions
diff --git a/drivers/mtd/core.c b/drivers/mtd/core.c
index 8601787286..b5916dab02 100644
--- a/drivers/mtd/core.c
+++ b/drivers/mtd/core.c
@@ -62,65 +62,15 @@ static ssize_t mtd_read(struct cdev *cdev, void* buf, size_t count,
#define MTDPGALG(x) ((x) & ~(mtd->writesize - 1))
#ifdef CONFIG_MTD_WRITE
-static int all_ff(const void *buf, int len)
-{
- int i;
- const uint8_t *p = buf;
-
- for (i = 0; i < len; i++)
- if (p[i] != 0xFF)
- return 0;
- return 1;
-}
-
static ssize_t mtd_write(struct cdev* cdev, const void *buf, size_t _count,
loff_t _offset, ulong flags)
{
struct mtd_info *mtd = cdev->priv;
- size_t retlen, now;
- int ret = 0;
- void *wrbuf = NULL;
- size_t count = _count;
- unsigned long offset = _offset;
-
- if (NOTALIGNED(offset)) {
- printf("offset 0x%0lx not page aligned\n", offset);
- return -EINVAL;
- }
-
- dev_dbg(cdev->dev, "write: offset: 0x%08lx count: 0x%zx\n", offset, count);
- while (count) {
- now = count > mtd->writesize ? mtd->writesize : count;
-
- if (NOTALIGNED(now)) {
- dev_dbg(cdev->dev, "not aligned: %d %ld\n",
- mtd->writesize,
- (offset % mtd->writesize));
- wrbuf = xmalloc(mtd->writesize);
- memset(wrbuf, 0xff, mtd->writesize);
- memcpy(wrbuf + (offset % mtd->writesize), buf, now);
- if (!all_ff(wrbuf, mtd->writesize))
- ret = mtd->write(mtd, MTDPGALG(offset),
- mtd->writesize, &retlen,
- wrbuf);
- free(wrbuf);
- } else {
- if (!all_ff(buf, mtd->writesize))
- ret = mtd->write(mtd, offset, now, &retlen,
- buf);
- dev_dbg(cdev->dev,
- "offset: 0x%08lx now: 0x%zx retlen: 0x%zx\n",
- offset, now, retlen);
- }
- if (ret)
- goto out;
+ size_t retlen;
+ int ret;
- offset += now;
- count -= now;
- buf += now;
- }
+ ret = mtd->write(mtd, _offset, _count, &retlen, buf);
-out:
return ret ? ret : _count;
}
#endif
diff --git a/drivers/mtd/mtdoob.c b/drivers/mtd/mtdoob.c
index c7bf40cef8..e5d803903a 100644
--- a/drivers/mtd/mtdoob.c
+++ b/drivers/mtd/mtdoob.c
@@ -73,6 +73,9 @@ static int add_mtdoob_device(struct mtd_info *mtd, char *devname, void **priv)
{
struct mtdoob *mtdoob;
+ if (mtd->oobsize == 0)
+ return 0;
+
mtdoob = xzalloc(sizeof(*mtdoob));
mtdoob->cdev.ops = &mtd_ops_oob;
mtdoob->cdev.size = (mtd->size / mtd->writesize) * mtd->oobsize;
diff --git a/drivers/mtd/nand/nand_write.c b/drivers/mtd/nand/nand_write.c
index 5ed04cee57..999712795c 100644
--- a/drivers/mtd/nand/nand_write.c
+++ b/drivers/mtd/nand/nand_write.c
@@ -273,13 +273,6 @@ int nand_do_write_ops(struct mtd_info *mtd, loff_t to,
if (!writelen)
return 0;
- /* reject writes, which are not page aligned */
- if (NOTALIGNED(to) || NOTALIGNED(ops->len)) {
- printk(KERN_NOTICE "nand_write: "
- "Attempt to write not page aligned data\n");
- return -EINVAL;
- }
-
column = to & (mtd->writesize - 1);
subpage = column || (writelen & (mtd->writesize - 1));