summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVivien Didelot <vivien.didelot@savoirfairelinux.com>2018-05-18 16:41:29 -0400
committerSascha Hauer <s.hauer@pengutronix.de>2018-05-22 08:41:21 +0200
commit0d4a43951b1a19d87f323deabd08adc667b2f71f (patch)
tree0ecec385dda8ca76d9b52880968e14b6b5211387
parent5913ff5a9044a1e36ceefe602853a14fecdd1cef (diff)
downloadbarebox-0d4a43951b1a19d87f323deabd08adc667b2f71f.tar.gz
barebox-0d4a43951b1a19d87f323deabd08adc667b2f71f.tar.xz
net: use dev_warn() when no MAC address is set
When a SoC such as VF610 has no addresses programmed for both its interfaces, the "No MAC address set" warning can be confusing: booting 'net' WARNING: net: warning: No MAC address set. Using random address a2:e8:be:79:72:01 WARNING: net: warning: No MAC address set. Using random address aa:d5:d7:10:c0:42 This patch uses dev_warn() instead and removes the redundant "warning": booting 'net' WARNING: eth0: No MAC address set. Using random address a2:e8:be:79:72:01 WARNING: eth1: No MAC address set. Using random address 4e:be:c4:bc:ce:36 Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> Acked-by: Sam Ravnborg <sam@ravnborg.org>
-rw-r--r--net/net.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/net.c b/net/net.c
index 94954677c5..d218554153 100644
--- a/net/net.c
+++ b/net/net.c
@@ -330,7 +330,7 @@ static struct net_connection *net_new(struct eth_device *edev, IPaddr_t dest,
char str[sizeof("xx:xx:xx:xx:xx:xx")];
random_ether_addr(edev->ethaddr);
ethaddr_to_string(edev->ethaddr, str);
- pr_warn("warning: No MAC address set. Using random address %s\n", str);
+ dev_warn(&edev->dev, "No MAC address set. Using random address %s\n", str);
eth_set_ethaddr(edev, edev->ethaddr);
}