diff options
author | Sascha Hauer <s.hauer@pengutronix.de> | 2014-02-20 10:54:28 +0100 |
---|---|---|
committer | Sascha Hauer <s.hauer@pengutronix.de> | 2014-02-20 14:46:33 +0100 |
commit | 5d22cb385695dc17cb226ba63db3c2a253a56bc6 (patch) | |
tree | 6e4977757107f91efb21bf2dd7e77beba143c0b7 | |
parent | 0a2a8f7059e6cb11e5d4eb882538b37f99d09ee3 (diff) | |
download | barebox-5d22cb385695dc17cb226ba63db3c2a253a56bc6.tar.gz barebox-5d22cb385695dc17cb226ba63db3c2a253a56bc6.tar.xz |
defaultenv: Align defaultenv array
The default environment buffer is an unsigned char array and thus
may be unaligned. Some decompression algorithms expect the buffer
to be sufficiently aligned for u32 accesses. We make this sure by
copying the default env to a temporary buffer. Instead of doing this
just add a __aligned(4) to the default environment.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
-rw-r--r-- | common/Makefile | 2 | ||||
-rw-r--r-- | common/startup.c | 11 |
2 files changed, 2 insertions, 11 deletions
diff --git a/common/Makefile b/common/Makefile index 3cfaae2e72..a52e96b40d 100644 --- a/common/Makefile +++ b/common/Makefile @@ -77,7 +77,7 @@ $(obj)/barebox_default_env: FORCE $(call cmd,envs) quiet_cmd_env_h = ENVH $@ -cmd_env_h = cat $< | (cd $(obj) && $(objtree)/scripts/bin2c default_environment) > $@; \ +cmd_env_h = cat $< | (cd $(obj) && $(objtree)/scripts/bin2c "__aligned(4) default_environment") > $@; \ echo "static const int default_environment_uncompress_size=`stat -c%s $(obj)/barebox_default_env`;" >> $@ $(obj)/barebox_default_env.h: $(obj)/barebox_default_env$(DEFAULT_COMPRESSION_SUFFIX) FORCE diff --git a/common/startup.c b/common/startup.c index 4bc5628f4a..6847b61b46 100644 --- a/common/startup.c +++ b/common/startup.c @@ -53,21 +53,12 @@ static int register_default_env(void) void *defaultenv; if (!IS_ENABLED(CONFIG_DEFAULT_COMPRESSION_NONE)) { - void *tmp = malloc(default_environment_size); - - if (!tmp) - return -ENOMEM; - - memcpy(tmp, default_environment, default_environment_size); defaultenv = xzalloc(default_environment_uncompress_size); - ret = uncompress(tmp, default_environment_size, + ret = uncompress(default_environment, default_environment_size, NULL, NULL, defaultenv, NULL, uncompress_err_stdout); - - free(tmp); - if (ret) { free(defaultenv); return ret; |