diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2021-11-30 21:30:26 +0100 |
|---|---|---|
| committer | Sascha Hauer <s.hauer@pengutronix.de> | 2021-12-07 10:08:25 +0100 |
| commit | 62f932aeb33568606be323b1669b0c904c88a489 (patch) | |
| tree | ad3630c30a17112bd0ad8b18f5df401bb2fa1114 | |
| parent | 6503eb21c6043b74a4a92d9b92057cbf45b6f313 (diff) | |
| download | barebox-62f932aeb33568606be323b1669b0c904c88a489.tar.gz barebox-62f932aeb33568606be323b1669b0c904c88a489.tar.xz | |
mci: bcm2835: Don't send MMC_CMD_GO_IDLE_STATE at the end of .init()
The core sends this command anyhow shortly after calling .init(). So
doing it in bcm2835_mci_reset() is only overhead if it succeeds and
if there is a problem it is noticed a tad earlier which has little
benefit compared to the timeout in bcm2835_mci_wait_command_done().
So simplify and drop the transfer.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.barebox.org/20211130203026.360693-1-u.kleine-koenig@pengutronix.de
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
| -rw-r--r-- | drivers/mci/mci-bcm2835.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/mci/mci-bcm2835.c b/drivers/mci/mci-bcm2835.c index 96a7fcd621..3380fa2afc 100644 --- a/drivers/mci/mci-bcm2835.c +++ b/drivers/mci/mci-bcm2835.c @@ -350,10 +350,7 @@ static int bcm2835_mci_reset(struct mci_host *mci, struct device_d *mci_dev) sdhci_write32(&host->sdhci, SDHCI_INT_STATUS, 0xFFFFFFFF); - /*Now write command 0 and see if we get response*/ - sdhci_write32(&host->sdhci, SDHCI_ARGUMENT, 0x0); - sdhci_write32(&host->sdhci, SDHCI_TRANSFER_MODE__COMMAND, 0x0); - return bcm2835_mci_wait_command_done(host); + return 0; } static int bcm2835_mci_probe(struct device_d *hw_dev) |