diff options
| author | Enrico Scholz <enrico.scholz@sigma-chemnitz.de> | 2022-01-14 11:52:35 +0100 |
|---|---|---|
| committer | Sascha Hauer <s.hauer@pengutronix.de> | 2022-01-17 10:13:15 +0100 |
| commit | 98159be6aa9fb7980244c2ef5f3a1665cdcb05e5 (patch) | |
| tree | 593ec689861e09fe718d5ede0aac0f1d00f1ce58 | |
| parent | 6584577004d094747a9b9923ed843be3621cfefc (diff) | |
| download | barebox-98159be6aa9fb7980244c2ef5f3a1665cdcb05e5.tar.gz barebox-98159be6aa9fb7980244c2ef5f3a1665cdcb05e5.tar.xz | |
usb:chipidea-imx: honor "phys" dtree property
Recent kernel devicetrees changed the "fsl,usbphy" property name to
"phys" on some platforms (e.g. iMX8) but the old one was kept on other
platforms (e.g. iMX6).
Check them both in the usb driver by preferring "phys".
NOTE: this fixes a hard lockup when booting NXP linux kernels on iMX8.
Signed-off-by: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
Link: https://lore.barebox.org/20220114105235.2580174-1-enrico.scholz@sigma-chemnitz.de
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
| -rw-r--r-- | drivers/usb/imx/chipidea-imx.c | 16 |
1 files changed, 14 insertions, 2 deletions
diff --git a/drivers/usb/imx/chipidea-imx.c b/drivers/usb/imx/chipidea-imx.c index f814778858..bf8b6f1eb8 100644 --- a/drivers/usb/imx/chipidea-imx.c +++ b/drivers/usb/imx/chipidea-imx.c @@ -218,6 +218,7 @@ static int imx_chipidea_probe(struct device_d *dev) struct resource *iores; struct imx_chipidea_data *imx_data; struct imxusb_platformdata *pdata = dev->platform_data; + char const *phynode_name; int ret; void __iomem *base; struct imx_chipidea *ci; @@ -262,8 +263,19 @@ static int imx_chipidea_probe(struct device_d *dev) if (!IS_ERR(ci->clk)) clk_enable(ci->clk); - if (of_property_read_bool(dev->device_node, "fsl,usbphy")) { - ci->phy = of_phy_get_by_phandle(dev, "fsl,usbphy", 0); + /* Device trees are using both "phys" and "fsl,usbphy". Prefer the + * more modern former one but fall back to the old one. + * + * Code should be removed when all devicetrees are using "phys" */ + if (of_property_read_bool(dev->device_node, "phys")) + phynode_name = "phys"; + else if (of_property_read_bool(dev->device_node, "fsl,usbphy")) + phynode_name = "fsl,usbphy"; + else + phynode_name = NULL; + + if (phynode_name) { + ci->phy = of_phy_get_by_phandle(dev, phynode_name, 0); if (IS_ERR(ci->phy)) { dev_err(dev, "Cannot get phy: %pe\n", ci->phy); return PTR_ERR(ci->phy); |