diff options
| author | Vicente Bergas <vicencb@gmail.com> | 2012-11-24 04:24:23 +0100 |
|---|---|---|
| committer | Sascha Hauer <s.hauer@pengutronix.de> | 2012-11-26 08:42:53 +0100 |
| commit | bd2fce751d4a2b8170962b53646209d6e14c7495 (patch) | |
| tree | 7bc9d021ffc54f439e04ca6a93bf283a58485195 | |
| parent | 21a911a0decf9dc0b6f591664a5b8617649a414f (diff) | |
| download | barebox-bd2fce751d4a2b8170962b53646209d6e14c7495.tar.gz barebox-bd2fce751d4a2b8170962b53646209d6e14c7495.tar.xz | |
uimage: fix misunderstanding in common/uimage.c
The option of reading the file at once was discarded because
the option of increasing the buffer size provided almost the
same benefit.
Signed-off-by: Vicente Bergas <vicencb@gmail.com>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
| -rw-r--r-- | common/uimage.c | 24 |
1 files changed, 0 insertions, 24 deletions
diff --git a/common/uimage.c b/common/uimage.c index 3f5a3d5cd0..8bcbfdda17 100644 --- a/common/uimage.c +++ b/common/uimage.c @@ -28,8 +28,6 @@ #include <rtc.h> #include <filetype.h> #include <memory.h> -#include <linux/stat.h> -#include <sizes.h> #ifdef CONFIG_UIMAGE_MULTI static inline int uimage_is_multi_image(struct uimage_handle *handle) @@ -384,33 +382,11 @@ struct resource *file_to_sdram(const char *filename, unsigned long adr) size_t ofs = 0; size_t now; int fd; - struct stat s; fd = open(filename, O_RDONLY); if (fd < 0) return NULL; - /* TODO: use fstat(fd, &s) when implemented and avoid reopening file */ - if (stat(filename, &s) == 0 && s.st_size <= SZ_1G) { - /* - * As the file size is known we can read it at once and improve - * transfer speed. - */ - size = s.st_size; - res = request_sdram_region("image", adr, size); - if (!res) { - printf("unable to request SDRAM 0x%08lx-0x%08lx\n", - adr, adr + size - 1); - goto out; - } - - now = read_full(fd, (void *)(res->start), size); - if (now < size) { - release_sdram_region(res); - res = NULL; - } - goto out; - } while (1) { res = request_sdram_region("image", adr, size); if (!res) { |