diff options
| author | Ian Abbott <abbotti@mev.co.uk> | 2017-04-21 10:53:25 +0100 |
|---|---|---|
| committer | Sascha Hauer <s.hauer@pengutronix.de> | 2017-04-21 14:41:34 +0200 |
| commit | ec01cbce2165deb3d814f0c031043fa999632eaa (patch) | |
| tree | 27035c6fa9ff3c91090dad10d79d5c88883e2178 | |
| parent | c0befa7cd0a16c6f3512124dac377fc9e1f46e34 (diff) | |
| download | barebox-ec01cbce2165deb3d814f0c031043fa999632eaa.tar.gz barebox-ec01cbce2165deb3d814f0c031043fa999632eaa.tar.xz | |
state: Fix "pack" returning freed data for DTB backend
`state_backend_format_dtb_pack()` passes a buffer containing state
packed in flattened DTB format back to its caller via its `buf`
parameter. It then frees the buffer before returning. This means the
caller (`state_save()`) will be working on freed buffer contents before
freeing the buffer a second time itself. Fix it by removing the
spurious call to `free()`.
This should fix a bug reported by Norbert Wiedmann in
<http://lists.infradead.org/pipermail/barebox/2017-April/029980.html>.
Cc: Norbert Wiedmann <info@n-wiedmann.de>
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
| -rw-r--r-- | common/state/backend_format_dtb.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/common/state/backend_format_dtb.c b/common/state/backend_format_dtb.c index 55fa1fc597..e88cda499b 100644 --- a/common/state/backend_format_dtb.c +++ b/common/state/backend_format_dtb.c @@ -120,8 +120,6 @@ static int state_backend_format_dtb_pack(struct state_backend_format *format, of_delete_node(fdtb->root); fdtb->root = root; - free(fdt); - return 0; } |