summaryrefslogtreecommitdiffstats
path: root/arch/arm/boards
diff options
context:
space:
mode:
authorLucas Stach <l.stach@pengutronix.de>2020-08-11 11:43:29 +0200
committerSascha Hauer <s.hauer@pengutronix.de>2020-08-17 06:36:41 +0200
commitb96cc34f9148e96e909ca9e263492fa3ce94c3a5 (patch)
tree785340191477384143691cbe609af50a2c4d086e /arch/arm/boards
parentd478fcd6d3dd92f1847c2bdfe44dba3c4ce626be (diff)
downloadbarebox-b96cc34f9148e96e909ca9e263492fa3ce94c3a5.tar.gz
barebox-b96cc34f9148e96e909ca9e263492fa3ce94c3a5.tar.xz
ARM: nxp-imx8mm-evk: always set up UART
When the TF-A is configured to have some output on the UART it does not set up the UART on its own, but just expects a pre-existing configuration. If Barebox did not set up the UART in the !DEBUG_LL case, TF-A will just hang without any user accessible debug output, which is a very non-obvious failure, so better be safe and always set up the UART in case TF-A wants to use it. Signed-off-by: Lucas Stach <l.stach@pengutronix.de> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Diffstat (limited to 'arch/arm/boards')
-rw-r--r--arch/arm/boards/nxp-imx8mm-evk/lowlevel.c10
1 files changed, 6 insertions, 4 deletions
diff --git a/arch/arm/boards/nxp-imx8mm-evk/lowlevel.c b/arch/arm/boards/nxp-imx8mm-evk/lowlevel.c
index cd1f7d168b..082aefb8c1 100644
--- a/arch/arm/boards/nxp-imx8mm-evk/lowlevel.c
+++ b/arch/arm/boards/nxp-imx8mm-evk/lowlevel.c
@@ -32,9 +32,12 @@ static void setup_uart(void)
imx8mm_setup_pad(IMX8MM_PAD_UART2_TXD_UART2_TX | UART_PAD_CTRL);
- imx8m_uart_setup_ll();
+ imx8mq_uart_setup((void *)MX8M_UART2_BASE_ADDR);
- putc_ll('>');
+ if (IS_ENABLED(CONFIG_DEBUG_LL)) {
+ imx8m_uart_setup_ll();
+ putc_ll('>');
+ }
}
static void pmic_reg_write(void *i2c, int reg, uint8_t val)
@@ -157,8 +160,7 @@ static void start_atf(void)
*/
static __noreturn noinline void nxp_imx8mm_evk_start(void)
{
- if (IS_ENABLED(CONFIG_DEBUG_LL))
- setup_uart();
+ setup_uart();
start_atf();