summaryrefslogtreecommitdiffstats
path: root/arch/arm
diff options
context:
space:
mode:
authorSascha Hauer <s.hauer@pengutronix.de>2021-05-17 20:54:17 +0200
committerSascha Hauer <s.hauer@pengutronix.de>2021-05-18 08:24:46 +0200
commit93b564d9acc7ce9b8ab1180e4af9e33aaad7d0f6 (patch)
tree8d7c1ec85f4b1da131fba367db09b471a25b39af /arch/arm
parentf08a3f28937e6c58ba60b84a302c8308126b6315 (diff)
downloadbarebox-93b564d9acc7ce9b8ab1180e4af9e33aaad7d0f6.tar.gz
barebox-93b564d9acc7ce9b8ab1180e4af9e33aaad7d0f6.tar.xz
ARM: i.MX bbu-external-nand: Do not modify image
struct bbu_data::image is const, so do not modify the image, but create a copy instead. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> Link: https://lore.barebox.org/20210517185424.32145-9-s.hauer@pengutronix.de Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Diffstat (limited to 'arch/arm')
-rw-r--r--arch/arm/mach-imx/imx-bbu-external-nand.c9
1 files changed, 8 insertions, 1 deletions
diff --git a/arch/arm/mach-imx/imx-bbu-external-nand.c b/arch/arm/mach-imx/imx-bbu-external-nand.c
index 8aa4f152a1..0f7cc51caf 100644
--- a/arch/arm/mach-imx/imx-bbu-external-nand.c
+++ b/arch/arm/mach-imx/imx-bbu-external-nand.c
@@ -39,7 +39,7 @@ static int imx_bbu_external_nand_update(struct bbu_handler *handler, struct bbu_
uint32_t num_bb = 0, bbt = 0;
loff_t offset = 0;
int block = 0, len, now, blocksize;
- void *image = data->image;
+ void *image = NULL;
ret = stat(data->devicefile, &s);
if (ret)
@@ -55,6 +55,12 @@ static int imx_bbu_external_nand_update(struct bbu_handler *handler, struct bbu_
if (ret)
goto out;
+ image = memdup(data->image, data->len);
+ if (!image) {
+ ret = -ENOMEM;
+ goto out;
+ }
+
blocksize = meminfo.erasesize;
size_need = data->len;
@@ -172,6 +178,7 @@ static int imx_bbu_external_nand_update(struct bbu_handler *handler, struct bbu_
out:
close(fd);
+ free(image);
return ret;
}