summaryrefslogtreecommitdiffstats
path: root/commands/flash.c
diff options
context:
space:
mode:
authorSascha Hauer <s.hauer@pengutronix.de>2016-04-18 11:56:00 +0200
committerSascha Hauer <s.hauer@pengutronix.de>2016-04-19 08:26:51 +0200
commitcb8cf33ce849f71f7fe1d717aa02b5669a54a19e (patch)
tree6d6f9692573033e1b516a896a8fb1333f25d1a37 /commands/flash.c
parent24a6b3f8eabf08b589a2860aee9b670fa88cd085 (diff)
downloadbarebox-cb8cf33ce849f71f7fe1d717aa02b5669a54a19e.tar.gz
barebox-cb8cf33ce849f71f7fe1d717aa02b5669a54a19e.tar.xz
fix erasing/protecting flashes with unspecified size
fixes: 81737c1 mtd: Fix erasing of devices >4GiB Several places erased a complete flash partition passing ~0 as count to erase(). With the above commit count to erase was changed from an unsigned type to a signed type, so the (count > f->size - offset) check in erase() no longer triggers and the ~0 count is no longer adjusted to the whole device size. Among other things this results in saveenv failures on NOR flashes. This patch fixes this by introducing an explicit macro for erasing the whole device which is tested for in erase(). All other negative values are rejected. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> Reported-by: Giorgio <giorgio.nicole@arcor.de>
Diffstat (limited to 'commands/flash.c')
-rw-r--r--commands/flash.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/commands/flash.c b/commands/flash.c
index 99d3cb7c3f..d881b4d399 100644
--- a/commands/flash.c
+++ b/commands/flash.c
@@ -32,7 +32,7 @@ static int do_flerase(int argc, char *argv[])
int fd;
char *filename = NULL;
struct stat s;
- loff_t start = 0, size = ~0;
+ loff_t start = 0, size;
int ret = 0;
if (argc == 1)