summaryrefslogtreecommitdiffstats
path: root/common/globalvar.c
diff options
context:
space:
mode:
authorAhmad Fatoum <a.fatoum@pengutronix.de>2020-09-30 09:19:55 +0200
committerSascha Hauer <s.hauer@pengutronix.de>2020-10-02 05:59:55 +0200
commit3f3b3c663a587bf67e2a6967c5935ed9d18503c4 (patch)
treee96394d638897c39bb8d31671b2df114667bd1bf /common/globalvar.c
parentef1bb8e21b0ad4fe43a76f69ea14b9fd31e4bdee (diff)
downloadbarebox-3f3b3c663a587bf67e2a6967c5935ed9d18503c4.tar.gz
barebox-3f3b3c663a587bf67e2a6967c5935ed9d18503c4.tar.xz
globalvar: fix uninitialized read of variable when no nvvars exist
When there are no nvvars, the function returns an uninitialized ret, return 0 in this case instead. Reported-by: clang-analyzer-10 Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Diffstat (limited to 'common/globalvar.c')
-rw-r--r--common/globalvar.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/common/globalvar.c b/common/globalvar.c
index 5bde86aad0..d3a109582d 100644
--- a/common/globalvar.c
+++ b/common/globalvar.c
@@ -668,7 +668,7 @@ int nvvar_save(void)
{
struct param_d *param;
const char *env = default_environment_path_get();
- int ret;
+ int ret = 0;
#define TMPDIR "/.env.tmp"
if (!nv_dirty || !env)
return 0;