path: root/common/startup.c
diff options
authorSascha Hauer <>2015-08-27 15:29:58 +0200
committerSascha Hauer <>2015-08-28 08:00:27 +0200
commit90e766a78fe8ebf8acdc19713e9194266c78c093 (patch)
tree58556b422db0819d335e60c4b5e573206d8c872d /common/startup.c
parentf38ba32965c5686c062884fab2e9f505015af82a (diff)
login: rework login mechanism
We used to have the login functionality in the /env/bin/init script. This is hard to review and it's too easy to break the login functionality with changes to this script. Move the places to ask for a password to C code where we have only a few places where we have to ask for a password. Mainly these are run_shell() and the menutree command. This patch introduces a login() function which will only return if the correct password has been entered. Following calls will return immediately without asking for a password again. Signed-off-by: Sascha Hauer <>
Diffstat (limited to 'common/startup.c')
1 files changed, 2 insertions, 5 deletions
diff --git a/common/startup.c b/common/startup.c
index 802b90e..4a303b2 100644
--- a/common/startup.c
+++ b/common/startup.c
@@ -108,13 +108,10 @@ void __noreturn start_barebox(void)
pr_info("running /env/bin/init...\n");
- if (!stat("/env/bin/init", &s)) {
+ if (!stat("/env/bin/init", &s))
run_command("source /env/bin/init");
- } else {
+ else
pr_err("/env/bin/init not found\n");
- while(run_command("login -t 0"));
- }
if (!barebox_main) {