summaryrefslogtreecommitdiffstats
path: root/common
diff options
context:
space:
mode:
authorSascha Hauer <s.hauer@pengutronix.de>2020-10-14 12:46:27 +0200
committerSascha Hauer <s.hauer@pengutronix.de>2020-10-14 12:46:27 +0200
commit11d027ac6b069c9371de3e1859dd0165a60826c3 (patch)
treed593d939bcf82fedf9f589fa21190d80cb6c718e /common
parent2da2a9c583775e966e940a21016309ca661979f5 (diff)
parentd5c47697a8f884d0ccc6c0958851a082d41b7a24 (diff)
downloadbarebox-11d027ac6b069c9371de3e1859dd0165a60826c3.tar.gz
barebox-11d027ac6b069c9371de3e1859dd0165a60826c3.tar.xz
Merge branch 'for-next/clang-analyzer' into master
Diffstat (limited to 'common')
-rw-r--r--common/blspec.c2
-rw-r--r--common/globalvar.c2
-rw-r--r--common/memsize.c2
3 files changed, 3 insertions, 3 deletions
diff --git a/common/blspec.c b/common/blspec.c
index 9499d32477..a07343f427 100644
--- a/common/blspec.c
+++ b/common/blspec.c
@@ -766,7 +766,7 @@ int blspec_scan_devices(struct bootentries *bootentries)
device_detect(dev);
for_each_block_device(bdev) {
- struct cdev *cdev = &bdev->cdev;
+ struct cdev *cdev;
list_for_each_entry(cdev, &bdev->dev->cdevs, devices_list) {
ret = blspec_scan_cdev(bootentries, cdev);
diff --git a/common/globalvar.c b/common/globalvar.c
index 09479da548..904acb94d7 100644
--- a/common/globalvar.c
+++ b/common/globalvar.c
@@ -674,7 +674,7 @@ int nvvar_save(void)
{
struct param_d *param;
const char *env = default_environment_path_get();
- int ret;
+ int ret = 0;
#define TMPDIR "/.env.tmp"
if (!nv_dirty || !env)
return 0;
diff --git a/common/memsize.c b/common/memsize.c
index 915ab87b34..2fd2b71457 100644
--- a/common/memsize.c
+++ b/common/memsize.c
@@ -58,7 +58,7 @@ long get_ram_size(volatile long *base, long maxsize)
*addr = 0;
sync ();
- if ((val = *addr) != 0) {
+ if (*addr != 0) {
/* Restore the original data before leaving the function.
*/
sync ();