path: root/defaultenv
diff options
authorMichael Forney <>2019-05-27 11:57:28 +0200
committerSascha Hauer <>2019-05-28 10:36:09 +0200
commitdefe614845cb85b0490ffb2ac5041a3d68615b3b (patch)
tree73f8af271df6eca922c671c0e9592d9bbe89c375 /defaultenv
parentbbb1ebc77319461c2296439a23e5c2d915c020fb (diff)
kbuild: Use ls(1) instead of stat(1) to obtain file size
stat(1) is not standardized and different implementations have their own (conflicting) flags for querying the size of a file. ls(1) provides the same information (value of st.st_size) in the 5th column, except when the file is a character or block device. This output is standardized[0]. The -n option turns on -l, which writes lines formatted like "%s %u %s %s %u %s %s\n", <file mode>, <number of links>, <owner name>, <group name>, <size>, <date and time>, <pathname> but instead of writing the <owner name> and <group name>, it writes the numeric owner and group IDs (this avoids /etc/passwd and /etc/group lookups as well as potential field splitting issues). The <size> field is specified as "the value that would be returned for the file in the st_size field of struct stat". To avoid duplicating logic in several locations in the tree, create scripts/ and update callers to use that instead of stat(1). [0] Signed-off-by: Michael Forney <> Signed-off-by: Masahiro Yamada <> [afa: imported script and adjusted barebox stat(1) callsites] Signed-off-by: Ahmad Fatoum <> Signed-off-by: Sascha Hauer <>
Diffstat (limited to 'defaultenv')
1 files changed, 2 insertions, 1 deletions
diff --git a/defaultenv/Makefile b/defaultenv/Makefile
index 950ac29..e030355 100644
--- a/defaultenv/Makefile
+++ b/defaultenv/Makefile
@@ -20,7 +20,8 @@ $(obj)/barebox_default_env: FORCE
quiet_cmd_env_h = ENVH $@
cmd_env_h = cat $< | (cd $(obj) && $(objtree)/scripts/bin2c "__aligned(4) default_environment") > $@; \
- echo "static const int default_environment_uncompress_size=`stat -c%s $(obj)/barebox_default_env`;" >> $@
+ echo "static const int default_environment_uncompress_size=`${CONFIG_SHELL} \"${srctree}/scripts/\" $(obj)/barebox_default_env`;" >> $@
$(obj)/barebox_default_env.h: $(obj)/barebox_default_env$(DEFAULT_COMPRESSION_SUFFIX) FORCE
$(call if_changed,env_h)