diff options
author | Sascha Hauer <s.hauer@pengutronix.de> | 2012-11-28 09:05:14 +0100 |
---|---|---|
committer | Sascha Hauer <s.hauer@pengutronix.de> | 2012-11-29 08:47:02 +0100 |
commit | 3e689025a5a0e9e9cab038ab2a537a425ca4d5d2 (patch) | |
tree | b04e06a94a0c85bfba1e17d3fd347e8085e2841c /drivers/clk/clk.c | |
parent | 159109f5ff2e3b0ee7c44685e2241605ae41b662 (diff) | |
download | barebox-3e689025a5a0e9e9cab038ab2a537a425ca4d5d2.tar.gz barebox-3e689025a5a0e9e9cab038ab2a537a425ca4d5d2.tar.xz |
clk: check for invalid clocks
Checking for invalid clocks on function entry allows users
to for example do a clk_set_rate(clk_lookup("myclk"), x) without
checking for validity of the result of clk_lookup first.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Diffstat (limited to 'drivers/clk/clk.c')
-rw-r--r-- | drivers/clk/clk.c | 23 |
1 files changed, 23 insertions, 0 deletions
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index bf61e5db94..ea93ff852c 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -43,6 +43,9 @@ int clk_enable(struct clk *clk) { int ret; + if (IS_ERR(clk)) + return PTR_ERR(clk); + if (!clk->enable_count) { ret = clk_parent_enable(clk); if (ret) @@ -64,6 +67,9 @@ int clk_enable(struct clk *clk) void clk_disable(struct clk *clk) { + if (IS_ERR(clk)) + return; + if (!clk->enable_count) return; @@ -82,6 +88,9 @@ unsigned long clk_get_rate(struct clk *clk) struct clk *parent; unsigned long parent_rate = 0; + if (IS_ERR(clk)) + return 0; + parent = clk_get_parent(clk); if (!IS_ERR_OR_NULL(parent)) parent_rate = clk_get_rate(parent); @@ -94,6 +103,9 @@ unsigned long clk_get_rate(struct clk *clk) long clk_round_rate(struct clk *clk, unsigned long rate) { + if (IS_ERR(clk)) + return 0; + return clk_get_rate(clk); } @@ -102,6 +114,9 @@ int clk_set_rate(struct clk *clk, unsigned long rate) struct clk *parent; unsigned long parent_rate = 0; + if (IS_ERR(clk)) + return PTR_ERR(clk); + parent = clk_get_parent(clk); if (parent) parent_rate = clk_get_rate(parent); @@ -131,6 +146,11 @@ int clk_set_parent(struct clk *clk, struct clk *parent) { int i; + if (IS_ERR(clk)) + return PTR_ERR(clk); + if (IS_ERR(parent)) + return PTR_ERR(parent); + if (!clk->num_parents) return -EINVAL; if (!clk->ops->set_parent) @@ -155,6 +175,9 @@ struct clk *clk_get_parent(struct clk *clk) { int idx; + if (IS_ERR(clk)) + return clk; + if (!clk->num_parents) return ERR_PTR(-ENODEV); |