diff options
author | Sascha Hauer <s.hauer@pengutronix.de> | 2011-11-08 10:57:57 +0100 |
---|---|---|
committer | Sascha Hauer <s.hauer@pengutronix.de> | 2011-11-08 11:13:11 +0100 |
commit | 01bedb677233c99a85c3014a2ff8d4794712b08c (patch) | |
tree | d42bc218af4248866716b0c179a034f564e73b14 /drivers/mtd/nand/nand_omap_gpmc.c | |
parent | 5b959a3e85982a603c7f3f4f5a606e6737095635 (diff) | |
download | barebox-01bedb677233c99a85c3014a2ff8d4794712b08c.tar.gz barebox-01bedb677233c99a85c3014a2ff8d4794712b08c.tar.xz |
mtd nand omap: make debugging output more useful
- add missing '\n' at line ends
- fix wrong argument type warnings
- remove too noisy debug in omap_hwcontrol
- add function names to debug printfs
- add 0x prefixes to hex values
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Diffstat (limited to 'drivers/mtd/nand/nand_omap_gpmc.c')
-rw-r--r-- | drivers/mtd/nand/nand_omap_gpmc.c | 27 |
1 files changed, 10 insertions, 17 deletions
diff --git a/drivers/mtd/nand/nand_omap_gpmc.c b/drivers/mtd/nand/nand_omap_gpmc.c index 50e0544d9f..e3c77ec318 100644 --- a/drivers/mtd/nand/nand_omap_gpmc.c +++ b/drivers/mtd/nand/nand_omap_gpmc.c @@ -194,14 +194,13 @@ static int omap_dev_ready(struct mtd_info *mtd) uint64_t start = get_time_ns(); unsigned long comp; - debug("mtd=%x", (unsigned int)mtd); /* What do we mean by assert and de-assert? */ comp = (oinfo->wait_pol == NAND_WAITPOL_HIGH) ? oinfo->wait_mon_mask : 0x0; while (1) { /* Breakout condition */ if (is_timeout(start, oinfo->timeout)) { - debug("timedout\n"); + debug("%s timedout\n", __func__); return -ETIMEDOUT; } /* if the wait is released, we are good to go */ @@ -226,7 +225,8 @@ static void gpmc_nand_wp(struct gpmc_nand_info *oinfo, int mode) { unsigned long config = readl(oinfo->gpmc_base + GPMC_CFG); - debug("mode=%x", mode); + debug("%s: mode=%x\n", __func__, mode); + if (mode) config &= ~(NAND_WP_BIT); /* WP is ON */ else @@ -251,8 +251,7 @@ static void omap_hwcontrol(struct mtd_info *mtd, int cmd, unsigned int ctrl) { struct nand_chip *nand = (struct nand_chip *)(mtd->priv); struct gpmc_nand_info *oinfo = (struct gpmc_nand_info *)(nand->priv); - debug("mtd=%x nand=%x cmd=%x ctrl = %x", (unsigned int)mtd, nand, - cmd, ctrl); + switch (ctrl) { case NAND_CTRL_CHANGE | NAND_CTRL_CLE: nand->IO_ADDR_W = oinfo->gpmc_command; @@ -285,8 +284,9 @@ static void omap_hwcontrol(struct mtd_info *mtd, int cmd, unsigned int ctrl) */ static unsigned int gen_true_ecc(u8 *ecc_buf) { - debug("ecc_buf=%x 1, 2 3 = %x %x %x", (unsigned int)ecc_buf, + debug("%s: eccbuf: 0x%02x 0x%02x 0x%02x\n", __func__, ecc_buf[0], ecc_buf[1], ecc_buf[2]); + return ecc_buf[0] | (ecc_buf[1] << 16) | ((ecc_buf[2] & 0xF0) << 20) | ((ecc_buf[2] & 0x0F) << 8); } @@ -476,9 +476,7 @@ static int omap_correct_data(struct mtd_info *mtd, uint8_t *dat, struct nand_chip *nand = (struct nand_chip *)(mtd->priv); struct gpmc_nand_info *oinfo = (struct gpmc_nand_info *)(nand->priv); - debug("mtd=%x dat=%x read_ecc=%x calc_ecc=%x", (unsigned int)mtd, - (unsigned int)dat, (unsigned int)read_ecc, - (unsigned int)calc_ecc); + debug("%s\n", __func__); switch (oinfo->ecc_mode) { case OMAP_ECC_HAMMING_CODE_HW_ROMCODE: @@ -766,14 +764,9 @@ static int gpmc_nand_probe(struct device_d *pdev) oinfo->gpmc_address = (void *)(cs_base + GPMC_CS_NAND_ADDRESS); oinfo->gpmc_data = (void *)(cs_base + GPMC_CS_NAND_DATA); oinfo->timeout = pdata->max_timeout; - debug("GPMC Details:\n" - "GPMC BASE=%x\n" - "CMD=%x\n" - "ADDRESS=%x\n" - "DATA=%x\n" - "CS_BASE=%x\n", - oinfo->gpmc_base, oinfo->gpmc_command, - oinfo->gpmc_address, oinfo->gpmc_data, cs_base); + dev_dbg(pdev, "GPMC base=0x%p cmd=0x%p address=0x%p data=0x%p cs_base=0x%p\n", + oinfo->gpmc_base, oinfo->gpmc_command, oinfo->gpmc_address, + oinfo->gpmc_data, cs_base); /* If we are 16 bit dev, our gpmc config tells us that */ if ((readl(cs_base) & 0x3000) == 0x1000) { |