diff options
| author | Ahmad Fatoum <a.fatoum@pengutronix.de> | 2019-07-15 16:55:22 +0200 |
|---|---|---|
| committer | Sascha Hauer <s.hauer@pengutronix.de> | 2019-07-18 08:52:45 +0200 |
| commit | c5ebd80a03bdafc3cb0ecd193f65468be308e746 (patch) | |
| tree | de7f6b0e42b7ceefe5cf397aa617867cc50afcfc /drivers/mtd | |
| parent | 41f5f8bb6ff00a6197d7a1f1a671c20895c22ac6 (diff) | |
| download | barebox-c5ebd80a03bdafc3cb0ecd193f65468be308e746.tar.gz barebox-c5ebd80a03bdafc3cb0ecd193f65468be308e746.tar.xz | |
UBI: silence erroneous GCC warning about uninitialized read
GCC reports following use of an uninitialized variable:
./drivers/mtd/ubi/eba.c: In function 'try_write_vid_and_data':
./drivers/mtd/ubi/eba.c:904:9: warning:
'opnum' may be used uninitialized in this function [-Wmaybe-uninitialized]
err = ubi_wl_put_peb(ubi, vol_id, lnum, opnum, 0);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
This is incorrect, because it's only called when err == 0 and opnum
is always initialized if err == 0. Silence the warning by initializing
a variable.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Diffstat (limited to 'drivers/mtd')
| -rw-r--r-- | drivers/mtd/ubi/eba.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mtd/ubi/eba.c b/drivers/mtd/ubi/eba.c index 3aae3029e5..cca6ec4ba9 100644 --- a/drivers/mtd/ubi/eba.c +++ b/drivers/mtd/ubi/eba.c @@ -865,7 +865,7 @@ static int try_write_vid_and_data(struct ubi_volume *vol, int lnum, int offset, int len) { struct ubi_device *ubi = vol->ubi; - int pnum, opnum, err, vol_id = vol->vol_id; + int pnum, opnum = -1, err, vol_id = vol->vol_id; pnum = ubi_wl_get_peb(ubi); if (pnum < 0) { |