diff options
| author | Beniamino Galvani <b.galvani@gmail.com> | 2014-05-19 22:34:59 +0200 |
|---|---|---|
| committer | Sascha Hauer <s.hauer@pengutronix.de> | 2014-05-20 07:44:41 +0200 |
| commit | b158af4f08a8f1ad24df52baff34389296adc2a1 (patch) | |
| tree | ed72497e365df167b1bd6165256927c444182a35 /drivers/net/arc_emac.c | |
| parent | b4ce62d3d23a2a910aefe803afc564c8b77ca205 (diff) | |
| download | barebox-b158af4f08a8f1ad24df52baff34389296adc2a1.tar.gz barebox-b158af4f08a8f1ad24df52baff34389296adc2a1.tar.xz | |
net: arc_emac: remove delay from mdio polling loop
Avoid unneeded delay when waiting for the completion of a mdio
operation and return as soon as possible.
Signed-off-by: Beniamino Galvani <b.galvani@gmail.com>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Diffstat (limited to 'drivers/net/arc_emac.c')
| -rw-r--r-- | drivers/net/arc_emac.c | 19 |
1 files changed, 6 insertions, 13 deletions
diff --git a/drivers/net/arc_emac.c b/drivers/net/arc_emac.c index 3f6f814955..23df3fdbcd 100644 --- a/drivers/net/arc_emac.c +++ b/drivers/net/arc_emac.c @@ -17,6 +17,7 @@ */ #include <asm/mmu.h> +#include <clock.h> #include <common.h> #include <net.h> #include <io.h> @@ -342,26 +343,18 @@ static int arc_emac_set_ethaddr(struct eth_device *edev, unsigned char *mac) return 0; } -/* Number of seconds we wait for "MDIO complete" flag to appear */ -#define ARC_MDIO_COMPLETE_POLL_COUNT 1 - static int arc_mdio_complete_wait(struct arc_emac_priv *priv) { - unsigned int i; - - for (i = 0; i < ARC_MDIO_COMPLETE_POLL_COUNT * 40; i++) { - unsigned int status = arc_reg_get(priv, R_STATUS); - - status &= MDIO_MASK; + uint64_t start = get_time_ns(); - if (status) { + while (!is_timeout(start, 1000 * MSECOND)) { + if (arc_reg_get(priv, R_STATUS) & MDIO_MASK) { /* Reset "MDIO complete" flag */ - arc_reg_set(priv, R_STATUS, status); + arc_reg_set(priv, R_STATUS, MDIO_MASK); return 0; } - - mdelay(25); } + return -ETIMEDOUT; } |