path: root/drivers/net
diff options
authorAhmad Fatoum <>2019-08-22 07:51:09 +0200
committerSascha Hauer <>2019-08-30 09:26:06 +0200
commitcb2f9447fef731a4e640e5032b47d1131adcb8ed (patch)
tree8ee04df20d7364ede46a3dfa6f56b47c70af57f8 /drivers/net
parent405c3fe243271d81150b805628234b2c10dbf732 (diff)
smc911x: fix inverted poll-for-ready
The ! operator is applied wrongly to only smc91xx_reg_read's return value, when probably the intention was for it to apply to the whole expression. However, wait_on_timeout keeps looping while the condition is false, so dropping the ! is the right thing to do. Do the right thing. Signed-off-by: Ahmad Fatoum <> Signed-off-by: Sascha Hauer <>
Diffstat (limited to 'drivers/net')
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c
index 0d5dcb3..ea7cea5 100644
--- a/drivers/net/smc911x.c
+++ b/drivers/net/smc911x.c
@@ -540,7 +540,7 @@ static int smc911x_probe(struct device_d *dev)
* poll the READY bit in PMT_CTRL. Any other access to the device is
* forbidden while this bit isn't set. Try for 100ms
- ret = wait_on_timeout(100 * MSECOND, !smc911x_reg_read(priv, PMT_CTRL) & PMT_CTRL_READY);
+ ret = wait_on_timeout(100 * MSECOND, smc911x_reg_read(priv, PMT_CTRL) & PMT_CTRL_READY);
if (!ret) {
dev_err(dev, "Device not READY in 100ms aborting\n");
return -ENODEV;