summaryrefslogtreecommitdiffstats
path: root/drivers/usb
diff options
context:
space:
mode:
authorAndrey Smirnov <andrew.smirnov@gmail.com>2019-05-22 00:34:09 -0700
committerSascha Hauer <s.hauer@pengutronix.de>2019-05-23 09:57:04 +0200
commit5f2110b07caa1ddbbadc68f1d34e2c60d8c94796 (patch)
tree035e747e916bd8a5cf97cd7132f788517e014c68 /drivers/usb
parentb221099d66a8d52e68c5ce074e082a8a0d1dbf3e (diff)
downloadbarebox-5f2110b07caa1ddbbadc68f1d34e2c60d8c94796.tar.gz
barebox-5f2110b07caa1ddbbadc68f1d34e2c60d8c94796.tar.xz
usb: host: ehci: Add a comment explaing IOC setting for data
Add a comment explaining the rationale behinde QT_TOKEN_IOC(req == NULL). Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Diffstat (limited to 'drivers/usb')
-rw-r--r--drivers/usb/host/ehci-hcd.c9
1 files changed, 9 insertions, 0 deletions
diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
index f0d899e82b..a6f497925e 100644
--- a/drivers/usb/host/ehci-hcd.c
+++ b/drivers/usb/host/ehci-hcd.c
@@ -362,6 +362,15 @@ ehci_submit_async(struct usb_device *dev, unsigned long pipe, void *buffer,
ret = ehci_prepare_qtd(ehci->dev,
td, QT_TOKEN_DT(toggle) |
+ /*
+ * We only want this qTD to
+ * generate an interrupt if
+ * this is a BULK
+ * request. Otherwise, we'll
+ * rely on following status
+ * stage qTD's IOC to notify us
+ * that transfer is complete
+ */
QT_TOKEN_IOC(req == NULL) |
QT_TOKEN_PID(pid),
buffer, length,