diff options
| author | iw3gtf@arcor.de <iw3gtf@arcor.de> | 2016-07-14 16:17:17 +0200 |
|---|---|---|
| committer | Sascha Hauer <s.hauer@pengutronix.de> | 2016-07-15 08:07:14 +0200 |
| commit | ca497ce66d6aa33838c6ebf587ee2a25d1910439 (patch) | |
| tree | d4063c66ad7dfa5c3d21a88dd6ca688884376f5c /drivers/video | |
| parent | 87c6a88f2aa37000f0fd98ac9dfbaf1747753506 (diff) | |
| download | barebox-ca497ce66d6aa33838c6ebf587ee2a25d1910439.tar.gz barebox-ca497ce66d6aa33838c6ebf587ee2a25d1910439.tar.xz | |
video/backlight-pwm: code readability improvement.
We use the local variable 'length' instead of the lengthy
'pwm_backlight->backlight.brightness_max' within pwm_backlight_parse_dt().
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Diffstat (limited to 'drivers/video')
| -rw-r--r-- | drivers/video/backlight-pwm.c | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/drivers/video/backlight-pwm.c b/drivers/video/backlight-pwm.c index 53cf4e98cf..5ff40a94c3 100644 --- a/drivers/video/backlight-pwm.c +++ b/drivers/video/backlight-pwm.c @@ -133,12 +133,11 @@ static int pwm_backlight_parse_dt(struct device_d *dev, if (!prop) return -EINVAL; - pwm_backlight->backlight.brightness_max = length / sizeof(u32); + length /= sizeof(u32); /* read brightness levels from DT property */ - if (pwm_backlight->backlight.brightness_max > 0) { - size_t size = sizeof(*pwm_backlight->levels) * - pwm_backlight->backlight.brightness_max; + if (length > 0) { + size_t size = sizeof(*pwm_backlight->levels) * length; pwm_backlight->levels = xzalloc(size); if (!pwm_backlight->levels) @@ -146,11 +145,11 @@ static int pwm_backlight_parse_dt(struct device_d *dev, ret = of_property_read_u32_array(node, "brightness-levels", pwm_backlight->levels, - pwm_backlight->backlight.brightness_max); + length); if (ret < 0) return ret; - for (i = 0; i < pwm_backlight->backlight.brightness_max; i++) + for (i = 0; i < length; i++) if (pwm_backlight->levels[i] > pwm_backlight->scale) pwm_backlight->scale = pwm_backlight->levels[i]; |