diff options
author | Sascha Hauer <s.hauer@pengutronix.de> | 2013-03-04 09:21:49 +0100 |
---|---|---|
committer | Sascha Hauer <s.hauer@pengutronix.de> | 2013-03-04 09:21:49 +0100 |
commit | 62ee96bd3b5e02173c0d9956c4f1e1a4de8f940d (patch) | |
tree | 1c9d519fb35c8c599bb31c4ee836f3ac135d933d /drivers | |
parent | 13408877f4c0d4b2784d3388dd4481369205e46a (diff) | |
parent | ef06284cd947c4e90a54a62d2c106789c6eaebe8 (diff) | |
download | barebox-62ee96bd3b5e02173c0d9956c4f1e1a4de8f940d.tar.gz barebox-62ee96bd3b5e02173c0d9956c4f1e1a4de8f940d.tar.xz |
Merge branch 'for-next/mtd'
Conflicts:
arch/arm/configs/eukrea_cpuimx27_defconfig
drivers/mtd/core.c
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/Kconfig | 1 | ||||
-rw-r--r-- | drivers/Makefile | 1 | ||||
-rw-r--r-- | drivers/mtd/Kconfig | 1 | ||||
-rw-r--r-- | drivers/mtd/Makefile | 1 | ||||
-rw-r--r-- | drivers/mtd/core.c | 111 | ||||
-rw-r--r-- | drivers/mtd/mtdraw.c | 2 | ||||
-rw-r--r-- | drivers/mtd/nand/nand_bbt.c | 4 | ||||
-rw-r--r-- | drivers/mtd/nor/Kconfig (renamed from drivers/nor/Kconfig) | 14 | ||||
-rw-r--r-- | drivers/mtd/nor/Makefile (renamed from drivers/nor/Makefile) | 0 | ||||
-rw-r--r-- | drivers/mtd/nor/cfi_flash.c (renamed from drivers/nor/cfi_flash.c) | 82 | ||||
-rw-r--r-- | drivers/mtd/nor/cfi_flash.h (renamed from drivers/nor/cfi_flash.h) | 1 | ||||
-rw-r--r-- | drivers/mtd/nor/cfi_flash_amd.c (renamed from drivers/nor/cfi_flash_amd.c) | 0 | ||||
-rw-r--r-- | drivers/mtd/nor/cfi_flash_intel.c (renamed from drivers/nor/cfi_flash_intel.c) | 0 | ||||
-rw-r--r-- | drivers/mtd/ubi/io.c | 8 |
14 files changed, 119 insertions, 107 deletions
diff --git a/drivers/Kconfig b/drivers/Kconfig index dac22de98b..16ca5b99b0 100644 --- a/drivers/Kconfig +++ b/drivers/Kconfig @@ -5,7 +5,6 @@ source "drivers/serial/Kconfig" source "drivers/net/Kconfig" source "drivers/spi/Kconfig" source "drivers/i2c/Kconfig" -source "drivers/nor/Kconfig" source "drivers/mtd/Kconfig" source "drivers/ata/Kconfig" source "drivers/usb/Kconfig" diff --git a/drivers/Makefile b/drivers/Makefile index 1fddee0dd4..f81bf99ac4 100644 --- a/drivers/Makefile +++ b/drivers/Makefile @@ -3,7 +3,6 @@ obj-$(CONFIG_ARM_AMBA) += amba/ obj-y += net/ obj-y += serial/ obj-y += mtd/ -obj-y += nor/ obj-y += usb/ obj-$(CONFIG_DISK) += ata/ obj-$(CONFIG_SPI) += spi/ diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig index 9450f5de8b..e94e6b1f63 100644 --- a/drivers/mtd/Kconfig +++ b/drivers/mtd/Kconfig @@ -21,6 +21,7 @@ config MTD_RAW_DEVICE prompt "mtdraw device to read/write both data+oob" source "drivers/mtd/devices/Kconfig" +source "drivers/mtd/nor/Kconfig" source "drivers/mtd/nand/Kconfig" source "drivers/mtd/ubi/Kconfig" diff --git a/drivers/mtd/Makefile b/drivers/mtd/Makefile index 4f97d9a6f3..82b2cc9e68 100644 --- a/drivers/mtd/Makefile +++ b/drivers/mtd/Makefile @@ -1,4 +1,5 @@ obj-$(CONFIG_NAND) += nand/ +obj-$(CONFIG_DRIVER_CFI) += nor/ obj-$(CONFIG_UBI) += ubi/ obj-y += devices/ obj-$(CONFIG_PARTITION_NEED_MTD) += partition.o diff --git a/drivers/mtd/core.c b/drivers/mtd/core.c index ef985564b5..b6c1d01434 100644 --- a/drivers/mtd/core.c +++ b/drivers/mtd/core.c @@ -62,16 +62,7 @@ int mtd_all_ff(const void *buf, unsigned int len) return 1; } -int mtd_block_isbad(struct mtd_info *mtd, loff_t ofs) -{ - if (!mtd->block_isbad) - return 0; - if (ofs < 0 || ofs > mtd->size) - return -EINVAL; - return mtd->block_isbad(mtd, ofs); -} - -static ssize_t mtd_read(struct cdev *cdev, void* buf, size_t count, +static ssize_t mtd_op_read(struct cdev *cdev, void* buf, size_t count, loff_t _offset, ulong flags) { struct mtd_info *mtd = cdev->priv; @@ -79,9 +70,10 @@ static ssize_t mtd_read(struct cdev *cdev, void* buf, size_t count, int ret; unsigned long offset = _offset; - debug("mtd_read: 0x%08lx 0x%08x\n", offset, count); + dev_dbg(cdev->dev, "read ofs: 0x%08lx count: 0x%08x\n", + offset, count); - ret = mtd->read(mtd, offset, count, &retlen, buf); + ret = mtd_read(mtd, offset, count, &retlen, buf); if(ret) { printf("err %d\n", ret); @@ -94,19 +86,19 @@ static ssize_t mtd_read(struct cdev *cdev, void* buf, size_t count, #define MTDPGALG(x) ((x) & ~(mtd->writesize - 1)) #ifdef CONFIG_MTD_WRITE -static ssize_t mtd_write(struct cdev* cdev, const void *buf, size_t _count, +static ssize_t mtd_op_write(struct cdev* cdev, const void *buf, size_t _count, loff_t _offset, ulong flags) { struct mtd_info *mtd = cdev->priv; size_t retlen; int ret; - ret = mtd->write(mtd, _offset, _count, &retlen, buf); + ret = mtd_write(mtd, _offset, _count, &retlen, buf); return ret ? ret : _count; } -static int mtd_erase(struct cdev *cdev, size_t count, loff_t offset) +static int mtd_op_erase(struct cdev *cdev, size_t count, loff_t offset) { struct mtd_info *mtd = cdev->priv; struct erase_info erase; @@ -124,7 +116,7 @@ static int mtd_erase(struct cdev *cdev, size_t count, loff_t offset) if (ret > 0) { printf("Skipping bad block at 0x%08x\n", erase.addr); } else { - ret = mtd->erase(mtd, &erase); + ret = mtd_erase(mtd, &erase); if (ret) return ret; } @@ -135,6 +127,20 @@ static int mtd_erase(struct cdev *cdev, size_t count, loff_t offset) return 0; } + +static ssize_t mtd_op_protect(struct cdev *cdev, size_t count, loff_t offset, int prot) +{ + struct mtd_info *mtd = cdev->priv; + + if (!mtd->unlock || !mtd->lock) + return -ENOSYS; + + if (prot) + return mtd_lock(mtd, offset, count); + else + return mtd_unlock(mtd, offset, count); +} + #endif /* CONFIG_MTD_WRITE */ int mtd_ioctl(struct cdev *cdev, int request, void *buf) @@ -159,10 +165,10 @@ int mtd_ioctl(struct cdev *cdev, int request, void *buf) #ifdef CONFIG_MTD_WRITE case MEMSETBADBLOCK: dev_dbg(cdev->dev, "MEMSETBADBLOCK: 0x%08llx\n", *offset); - ret = mtd->block_markbad(mtd, *offset); + ret = mtd_block_markbad(mtd, *offset); break; case MEMERASE: - ret = mtd_erase(cdev, ei->length, ei->start + cdev->offset); + ret = mtd_op_erase(cdev, ei->length, ei->start + cdev->offset); break; #endif case MEMGETINFO: @@ -201,11 +207,74 @@ int mtd_ioctl(struct cdev *cdev, int request, void *buf) return ret; } +int mtd_lock(struct mtd_info *mtd, loff_t ofs, uint64_t len) +{ + if (!mtd->lock) + return -EOPNOTSUPP; + if (ofs < 0 || ofs > mtd->size || len > mtd->size - ofs) + return -EINVAL; + if (!len) + return 0; + return mtd->lock(mtd, ofs, len); +} + +int mtd_unlock(struct mtd_info *mtd, loff_t ofs, uint64_t len) +{ + if (!mtd->unlock) + return -EOPNOTSUPP; + if (ofs < 0 || ofs > mtd->size || len > mtd->size - ofs) + return -EINVAL; + if (!len) + return 0; + return mtd->unlock(mtd, ofs, len); +} + +int mtd_block_isbad(struct mtd_info *mtd, loff_t ofs) +{ + if (!mtd->block_isbad) + return 0; + + if (ofs < 0 || ofs > mtd->size) + return -EINVAL; + + return mtd->block_isbad(mtd, ofs); +} + +int mtd_block_markbad(struct mtd_info *mtd, loff_t ofs) +{ + int ret; + + if (mtd->block_markbad) + ret = mtd->block_markbad(mtd, ofs); + else + ret = -ENOSYS; + + return ret; +} + +int mtd_read(struct mtd_info *mtd, loff_t from, size_t len, size_t *retlen, + u_char *buf) +{ + return mtd->read(mtd, from, len, retlen, buf); +} + +int mtd_write(struct mtd_info *mtd, loff_t to, size_t len, size_t *retlen, + const u_char *buf) +{ + return mtd->write(mtd, to, len, retlen, buf); +} + +int mtd_erase(struct mtd_info *mtd, struct erase_info *instr) +{ + return mtd->erase(mtd, instr); +} + static struct file_operations mtd_ops = { - .read = mtd_read, + .read = mtd_op_read, #ifdef CONFIG_MTD_WRITE - .write = mtd_write, - .erase = mtd_erase, + .write = mtd_op_write, + .erase = mtd_op_erase, + .protect = mtd_op_protect, #endif .ioctl = mtd_ioctl, .lseek = dev_lseek_default, diff --git a/drivers/mtd/mtdraw.c b/drivers/mtd/mtdraw.c index ec7769249b..5aaa0172da 100644 --- a/drivers/mtd/mtdraw.c +++ b/drivers/mtd/mtdraw.c @@ -245,7 +245,7 @@ static int mtdraw_erase(struct cdev *cdev, size_t count, loff_t _offset) if (ret > 0) { printf("Skipping bad block at 0x%08x\n", erase.addr); } else { - ret = mtd->erase(mtd, &erase); + ret = mtd_erase(mtd, &erase); if (ret) return ret; } diff --git a/drivers/mtd/nand/nand_bbt.c b/drivers/mtd/nand/nand_bbt.c index f7ae7cd717..56396bfd86 100644 --- a/drivers/mtd/nand/nand_bbt.c +++ b/drivers/mtd/nand/nand_bbt.c @@ -160,7 +160,7 @@ static int read_bbt(struct mtd_info *mtd, uint8_t *buf, int page, int num, while (totlen) { len = min(totlen, (size_t) (1 << this->bbt_erase_shift)); - res = mtd->read(mtd, from, len, &retlen, buf); + res = mtd_read(mtd, from, len, &retlen, buf); if (res < 0) { if (retlen != len) { pr_info("nand_bbt: Error reading bad block table\n"); @@ -669,7 +669,7 @@ static int write_bbt(struct mtd_info *mtd, uint8_t *buf, /* Make it block aligned */ to &= ~((loff_t) ((1 << this->bbt_erase_shift) - 1)); len = 1 << this->bbt_erase_shift; - res = mtd->read(mtd, to, len, &retlen, buf); + res = mtd_read(mtd, to, len, &retlen, buf); if (res < 0) { if (retlen != len) { pr_info("nand_bbt: Error " diff --git a/drivers/nor/Kconfig b/drivers/mtd/nor/Kconfig index c8ce24ff03..44a418405b 100644 --- a/drivers/nor/Kconfig +++ b/drivers/mtd/nor/Kconfig @@ -1,7 +1,5 @@ -menu "flash drivers" - menuconfig DRIVER_CFI - bool "CFI" + bool "CFI NOR flash support" help If you have NOR Flash devices connected to your system and wish to use them say yes here. @@ -10,17 +8,14 @@ if DRIVER_CFI config DRIVER_CFI_INTEL default y - depends on DRIVER_CFI bool "Support Intel flash chips" config DRIVER_CFI_AMD default y - depends on DRIVER_CFI bool "support AMD flash chips" config DRIVER_CFI_BANK_WIDTH_1 bool "Support 8-bit buswidth" - depends on DRIVER_CFI default y help If you wish to support CFI devices on a physical bus which is @@ -28,7 +23,6 @@ config DRIVER_CFI_BANK_WIDTH_1 config DRIVER_CFI_BANK_WIDTH_2 bool "Support 16-bit buswidth" - depends on DRIVER_CFI default y help If you wish to support CFI devices on a physical bus which is @@ -36,7 +30,6 @@ config DRIVER_CFI_BANK_WIDTH_2 config DRIVER_CFI_BANK_WIDTH_4 bool "Support 32-bit buswidth" - depends on DRIVER_CFI default y help If you wish to support CFI devices on a physical bus which is @@ -44,16 +37,11 @@ config DRIVER_CFI_BANK_WIDTH_4 config DRIVER_CFI_BANK_WIDTH_8 bool "Support 64-bit buswidth" - depends on DRIVER_CFI - default n help If you wish to support CFI devices on a physical bus which is 64 bits wide, say 'Y'. config CFI_BUFFER_WRITE bool "use cfi driver with buffer write" - depends on DRIVER_CFI || DRIVER_CFI endif - -endmenu diff --git a/drivers/nor/Makefile b/drivers/mtd/nor/Makefile index d2550436d2..d2550436d2 100644 --- a/drivers/nor/Makefile +++ b/drivers/mtd/nor/Makefile diff --git a/drivers/nor/cfi_flash.c b/drivers/mtd/nor/cfi_flash.c index acdc38654f..0cfac2d036 100644 --- a/drivers/nor/cfi_flash.c +++ b/drivers/mtd/nor/cfi_flash.c @@ -454,10 +454,8 @@ flash_sect_t find_sector (struct flash_info *info, ulong addr) return sector; } -static int __cfi_erase(struct cdev *cdev, size_t count, loff_t offset, - int verbose) +static int cfi_erase(struct flash_info *finfo, size_t count, loff_t offset) { - struct flash_info *finfo = (struct flash_info *)cdev->priv; unsigned long start, end; int i, ret = 0; @@ -467,9 +465,6 @@ static int __cfi_erase(struct cdev *cdev, size_t count, loff_t offset, end = find_sector(finfo, (unsigned long)finfo->base + offset + count - 1); - if (verbose) - init_progression_bar(end - start); - for (i = start; i <= end; i++) { ret = finfo->cfi_cmd_set->flash_erase_one(finfo, i); if (ret) @@ -479,21 +474,11 @@ static int __cfi_erase(struct cdev *cdev, size_t count, loff_t offset, ret = -EINTR; goto out; } - - if (verbose) - show_progress(i - start); } out: - if (verbose) - putchar('\n'); return ret; } -static int cfi_erase(struct cdev *cdev, size_t count, loff_t offset) -{ - return __cfi_erase(cdev, count, offset, 1); -} - /* * Copy memory to flash, returns: * 0 - OK @@ -626,18 +611,13 @@ static int flash_real_protect (struct flash_info *info, long sector, int prot) return retcode; } -static int cfi_protect(struct cdev *cdev, size_t count, loff_t offset, int prot) +static int cfi_mtd_protect(struct flash_info *finfo, loff_t offset, size_t len, int prot) { - struct flash_info *finfo = (struct flash_info *)cdev->priv; unsigned long start, end; int i, ret = 0; - const char *action = (prot? "protect" : "unprotect"); - - printf("%s: %s 0x%p (size %zu)\n", __func__, - action, finfo->base + offset, count); start = find_sector(finfo, (unsigned long)finfo->base + offset); - end = find_sector(finfo, (unsigned long)finfo->base + offset + count - 1); + end = find_sector(finfo, (unsigned long)finfo->base + offset + len - 1); for (i = start; i <= end; i++) { ret = flash_real_protect (finfo, i, prot); @@ -645,20 +625,21 @@ static int cfi_protect(struct cdev *cdev, size_t count, loff_t offset, int prot) goto out; } out: - putchar('\n'); return ret; } -static ssize_t cfi_write(struct cdev *cdev, const void *buf, size_t count, loff_t offset, ulong flags) +static int cfi_mtd_lock(struct mtd_info *mtd, loff_t offset, size_t len) { - struct flash_info *finfo = (struct flash_info *)cdev->priv; - int ret; + struct flash_info *finfo = container_of(mtd, struct flash_info, mtd); + + return cfi_mtd_protect(finfo, offset, len, 1); +} - debug("cfi_write: buf=0x%p addr=0x%p count=0x%08zx\n", - buf, finfo->base + offset, count); +static int cfi_mtd_unlock(struct mtd_info *mtd, loff_t offset, size_t len) +{ + struct flash_info *finfo = container_of(mtd, struct flash_info, mtd); - ret = write_buff(finfo, buf, (unsigned long)finfo->base + offset, count); - return ret == 0 ? count : -1; + return cfi_mtd_protect(finfo, offset, len, 0); } static void cfi_info (struct device_d* dev) @@ -908,15 +889,6 @@ int flash_isset(struct flash_info *info, flash_sect_t sect, return retval; } -struct file_operations cfi_ops = { - .read = mem_read, - .write = cfi_write, - .lseek = dev_lseek_default, - .erase = cfi_erase, - .protect = cfi_protect, - .memmap = generic_memmap_ro, -}; - static int cfi_mtd_read(struct mtd_info *mtd, loff_t from, size_t len, size_t *retlen, u_char *buf) { @@ -943,10 +915,9 @@ static int cfi_mtd_write(struct mtd_info *mtd, loff_t to, size_t len, static int cfi_mtd_erase(struct mtd_info *mtd, struct erase_info *instr) { struct flash_info *info = container_of(mtd, struct flash_info, mtd); - struct cdev *cdev = &info->cdev; int ret; - ret = __cfi_erase(cdev, instr->len, instr->addr, 0); + ret = cfi_erase(info, instr->len, instr->addr); if (ret) { instr->state = MTD_ERASE_FAILED; @@ -966,21 +937,23 @@ static void cfi_init_mtd(struct flash_info *info) mtd->read = cfi_mtd_read; mtd->write = cfi_mtd_write; mtd->erase = cfi_mtd_erase; + mtd->lock = cfi_mtd_lock; + mtd->unlock = cfi_mtd_unlock; mtd->size = info->size; - mtd->name = info->cdev.name; mtd->erasesize = info->eraseregions[1].erasesize; /* FIXME */ mtd->writesize = 1; mtd->subpage_sft = 0; mtd->eraseregions = info->eraseregions; mtd->numeraseregions = info->numeraseregions; mtd->flags = MTD_CAP_NORFLASH; - info->cdev.mtd = mtd; + mtd->type = MTD_NORFLASH; + + add_mtd_device(mtd, "nor"); } static int cfi_probe (struct device_d *dev) { struct flash_info *info = xzalloc(sizeof(*info)); - int cfinum; dev->priv = (void *)info; @@ -999,24 +972,7 @@ static int cfi_probe (struct device_d *dev) dev_info(dev, "found cfi flash at %p, size %ld\n", info->base, info->size); - if (dev->id < 0) - cfinum = cdev_find_free_index("nor"); - else - cfinum = dev->id; - - info->cdev.name = asprintf("nor%d", cfinum); - info->cdev.size = info->size; - info->cdev.dev = dev; - info->cdev.ops = &cfi_ops; - info->cdev.priv = info; - - if (IS_ENABLED(CONFIG_PARTITION_NEED_MTD)) - cfi_init_mtd(info); - - devfs_create(&info->cdev); - - if (dev->device_node) - of_parse_partitions(info->cdev.name, dev->device_node); + cfi_init_mtd(info); return 0; } diff --git a/drivers/nor/cfi_flash.h b/drivers/mtd/nor/cfi_flash.h index 944cdde660..bcf5c40c73 100644 --- a/drivers/nor/cfi_flash.h +++ b/drivers/mtd/nor/cfi_flash.h @@ -74,7 +74,6 @@ struct flash_info { ulong addr_unlock1; /* unlock address 1 for AMD flash roms */ ulong addr_unlock2; /* unlock address 2 for AMD flash roms */ struct cfi_cmd_set *cfi_cmd_set; - struct cdev cdev; struct mtd_info mtd; int numeraseregions; struct mtd_erase_region_info *eraseregions; diff --git a/drivers/nor/cfi_flash_amd.c b/drivers/mtd/nor/cfi_flash_amd.c index 45c59b9d01..45c59b9d01 100644 --- a/drivers/nor/cfi_flash_amd.c +++ b/drivers/mtd/nor/cfi_flash_amd.c diff --git a/drivers/nor/cfi_flash_intel.c b/drivers/mtd/nor/cfi_flash_intel.c index 32e581a395..32e581a395 100644 --- a/drivers/nor/cfi_flash_intel.c +++ b/drivers/mtd/nor/cfi_flash_intel.c diff --git a/drivers/mtd/ubi/io.c b/drivers/mtd/ubi/io.c index e3598b9d9d..000fc5d921 100644 --- a/drivers/mtd/ubi/io.c +++ b/drivers/mtd/ubi/io.c @@ -151,7 +151,7 @@ int ubi_io_read(const struct ubi_device *ubi, void *buf, int pnum, int offset, addr = (loff_t)pnum * ubi->peb_size + offset; retry: - err = ubi->mtd->read(ubi->mtd, addr, len, &read, buf); + err = mtd_read(ubi->mtd, addr, len, &read, buf); if (err) { if (err == -EUCLEAN) { /* @@ -265,7 +265,7 @@ int ubi_io_write(struct ubi_device *ubi, const void *buf, int pnum, int offset, } addr = (loff_t)pnum * ubi->peb_size + offset; - err = ubi->mtd->write(ubi->mtd, addr, len, &written, buf); + err = mtd_write(ubi->mtd, addr, len, &written, buf); if (err) { ubi_err("error %d while writing %d bytes to PEB %d:%d, written" " %zd bytes", err, len, pnum, offset, written); @@ -315,7 +315,7 @@ retry: ei.callback = erase_callback; ei.priv = (unsigned long)&wq; - err = ubi->mtd->erase(ubi->mtd, &ei); + err = mtd_erase(ubi->mtd, &ei); if (err) { if (retries++ < UBI_IO_RETRIES) { dbg_io("error %d while erasing PEB %d, retry", @@ -1239,7 +1239,7 @@ static int paranoid_check_all_ff(struct ubi_device *ubi, int pnum, int offset, loff_t addr = (loff_t)pnum * ubi->peb_size + offset; mutex_lock(&ubi->dbg_buf_mutex); - err = ubi->mtd->read(ubi->mtd, addr, len, &read, ubi->dbg_peb_buf); + err = mtd_read(ubi->mtd, addr, len, &read, ubi->dbg_peb_buf); if (err && err != -EUCLEAN) { ubi_err("error %d while reading %d bytes from PEB %d:%d, " "read %zd bytes", err, len, pnum, offset, read); |