diff options
| author | Richard Weinberger <richard@nod.at> | 2013-09-28 15:55:15 +0200 |
|---|---|---|
| committer | Sascha Hauer <s.hauer@pengutronix.de> | 2014-01-07 11:03:24 +0100 |
| commit | 71791bd2cbbd7f8f91600a0e299fcae56eeeaa51 (patch) | |
| tree | 1e45c863daf22c3014f431b79727f693f23b3469 /drivers | |
| parent | dee73c54b050a772e9e5814c9da9905fc9b8e4fa (diff) | |
| download | barebox-71791bd2cbbd7f8f91600a0e299fcae56eeeaa51.tar.gz barebox-71791bd2cbbd7f8f91600a0e299fcae56eeeaa51.tar.xz | |
UBI: Fix memory leak in ubi_attach_fastmap() error path
On error we have to free all three temporary lists.
Reported-by: Richard Genoud <richard.genoud@gmail.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/mtd/ubi/fastmap.c | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c index 8963e0670b..aaa9f55ad6 100644 --- a/drivers/mtd/ubi/fastmap.c +++ b/drivers/mtd/ubi/fastmap.c @@ -830,6 +830,19 @@ static int ubi_attach_fastmap(struct ubi_device *ubi, fail_bad: ret = UBI_BAD_FASTMAP; fail: + list_for_each_entry_safe(tmp_aeb, _tmp_aeb, &used, u.list) { + free(tmp_aeb); + list_del(&tmp_aeb->u.list); + } + list_for_each_entry_safe(tmp_aeb, _tmp_aeb, &eba_orphans, u.list) { + free(tmp_aeb); + list_del(&tmp_aeb->u.list); + } + list_for_each_entry_safe(tmp_aeb, _tmp_aeb, &lfree, u.list) { + free(tmp_aeb); + list_del(&tmp_aeb->u.list); + } + return ret; } |