diff options
| author | Sascha Hauer <s.hauer@pengutronix.de> | 2013-12-19 16:17:40 +0100 |
|---|---|---|
| committer | Sascha Hauer <s.hauer@pengutronix.de> | 2013-12-20 15:04:29 +0100 |
| commit | a8fd9bfd126cee8a02400f49301fb58228a2bf26 (patch) | |
| tree | e3e7f02facda5a8221592309d4e24ce3b547a910 /drivers | |
| parent | 26f2c815d1768e16bd4b953ee24e2dcf41700258 (diff) | |
| download | barebox-a8fd9bfd126cee8a02400f49301fb58228a2bf26.tar.gz barebox-a8fd9bfd126cee8a02400f49301fb58228a2bf26.tar.xz | |
mtd: fix wrong return values in cdev read
mtd->read returns the number of bitflips as positive numbers.
Instead of returning these numbers Return -EUCLEAN when the bitflip
threshold has been reached, 0 otherwise.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/mtd/core.c | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/drivers/mtd/core.c b/drivers/mtd/core.c index 33f900e732..0abe6675e7 100644 --- a/drivers/mtd/core.c +++ b/drivers/mtd/core.c @@ -75,12 +75,11 @@ static ssize_t mtd_op_read(struct cdev *cdev, void* buf, size_t count, offset, count); ret = mtd_read(mtd, offset, count, &retlen, buf); - - if(ret) { - printf("err %d\n", ret); + if (ret < 0) return ret; - } - return retlen; + if (mtd->ecc_strength == 0) + return retlen; /* device lacks ecc */ + return ret >= mtd->bitflip_threshold ? -EUCLEAN : retlen; } #define NOTALIGNED(x) (x & (mtd->writesize - 1)) != 0 |