summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorOleksij Rempel <linux@rempel-privat.de>2018-11-20 21:07:07 +0100
committerSascha Hauer <s.hauer@pengutronix.de>2018-11-21 09:08:09 +0100
commit068e935704cac7058b1a5d325137af2788f326c3 (patch)
treea82c9d0e0dc6239cb958d9366131b23c52eb24c0 /drivers
parentb291ca7a28d75cd83bdc9bf17419db5a06aebcec (diff)
downloadbarebox-068e935704cac7058b1a5d325137af2788f326c3.tar.gz
barebox-068e935704cac7058b1a5d325137af2788f326c3.tar.xz
pinctrl: tegra30: fix "Possible null pointer dereference: group" warning
The code is correct but it takes more seconds for me to understand. And static code analyzer do not understand it at all. Signed-off-by: Oleksij Rempel <linux@rempel-privat.de> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/pinctrl/pinctrl-tegra30.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/pinctrl/pinctrl-tegra30.c b/drivers/pinctrl/pinctrl-tegra30.c
index d9b49c57d9..ffb04eebbf 100644
--- a/drivers/pinctrl/pinctrl-tegra30.c
+++ b/drivers/pinctrl/pinctrl-tegra30.c
@@ -658,8 +658,8 @@ static int pinctrl_tegra30_set_drvstate(struct pinctrl_tegra30 *ctrl,
break;
}
}
- /* if no matching drivegroup is found */
- if (i == ctrl->drvdata->num_drvgrps)
+
+ if (!group)
return 0;
regaddr = ctrl->regs.ctrl + (group->reg >> 2);