diff options
| author | Sascha Hauer <s.hauer@pengutronix.de> | 2018-09-21 10:30:01 +0200 |
|---|---|---|
| committer | Sascha Hauer <s.hauer@pengutronix.de> | 2018-09-21 13:14:15 +0200 |
| commit | 110d80996104b419176ec18a28b2f3a51fb0a2a8 (patch) | |
| tree | eeebc89172aaaaacadb512e5d65234c786bcf4a5 /drivers | |
| parent | e6b0633b51f9cacb0f0e649e44a56dce50883d8d (diff) | |
| download | barebox-110d80996104b419176ec18a28b2f3a51fb0a2a8.tar.gz barebox-110d80996104b419176ec18a28b2f3a51fb0a2a8.tar.xz | |
mtd: mtdraw: Simplify error path
We do not need a printf when writing fails, it's the callers job
to report this. Remove printf and simplify the error path a bit.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/mtd/mtdraw.c | 16 |
1 files changed, 7 insertions, 9 deletions
diff --git a/drivers/mtd/mtdraw.c b/drivers/mtd/mtdraw.c index 4f7c3b836c..d0dde0dee2 100644 --- a/drivers/mtd/mtdraw.c +++ b/drivers/mtd/mtdraw.c @@ -146,11 +146,11 @@ static ssize_t mtdraw_read(struct cdev *cdev, void *buf, size_t count, count -= ret; retlen += ret; } + if (ret < 0) - printf("err %zd\n", ret); - else - ret = retlen; - return ret; + return ret; + + return retlen; } #ifdef CONFIG_MTD_WRITE @@ -231,12 +231,10 @@ static ssize_t mtdraw_write(struct cdev *cdev, const void *buf, size_t count, retlen += count; } - if (ret < 0) { - printf("err %d\n", ret); + if (ret < 0) return ret; - } else { - return retlen; - } + + return retlen; } static int mtdraw_erase(struct cdev *cdev, loff_t count, loff_t offset) |