summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>2019-09-04 13:18:51 +0200
committerSascha Hauer <s.hauer@pengutronix.de>2019-09-06 09:13:21 +0200
commit59e81b6edd48d49030033a2bc46e584c9868f3ad (patch)
tree1a3921ffaa2c530f3fa735fcc97d132a03ae5c76 /drivers
parentf539d54de049730096016ca9d243dedca1e637fb (diff)
downloadbarebox-59e81b6edd48d49030033a2bc46e584c9868f3ad.tar.gz
barebox-59e81b6edd48d49030033a2bc46e584c9868f3ad.tar.xz
video/stm: fix return value handling for of_get_display_timings()
of_get_display_timings() returns NULL on failure, not an error pointer. Fixes: 16fd24847d7a ("video: stmfb: Add device tree support") Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/video/stm.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/video/stm.c b/drivers/video/stm.c
index 0c190d36ae..d4a618fe50 100644
--- a/drivers/video/stm.c
+++ b/drivers/video/stm.c
@@ -551,9 +551,9 @@ static int stmfb_probe(struct device_d *hw_dev)
}
modes = of_get_display_timings(display);
- if (IS_ERR(modes)) {
+ if (!modes) {
dev_err(hw_dev, "unable to parse display timings\n");
- return PTR_ERR(modes);
+ return -EINVAL;
}
fbi.info.modes.modes = modes->modes;