diff options
| author | Mike Nawrocki <michael.nawrocki@gtri.gatech.edu> | 2021-01-29 12:44:35 -0500 |
|---|---|---|
| committer | Sascha Hauer <s.hauer@pengutronix.de> | 2021-02-01 11:53:25 +0100 |
| commit | 869fe6fdd727f46b80aa27d08ccac1b3e7abf1aa (patch) | |
| tree | b0ed6f73f8c14e0d44ef46342df635dc2abe5045 /drivers | |
| parent | 2782aae950c2d9f3d90a14a9b4aa0764247f782f (diff) | |
| download | barebox-869fe6fdd727f46b80aa27d08ccac1b3e7abf1aa.tar.gz barebox-869fe6fdd727f46b80aa27d08ccac1b3e7abf1aa.tar.xz | |
drivers: smc911x fix inverted wait_on_timeout
The smc911x driver probe routine polls the READY bit using
wait_on_timeout, which returns 0 on success. The error check following
the wait_on_timeout invocation in the probe routine interprets a
returned 0 as failure.
This patch correctly interprets the return value of wait_on_timeout.
Signed-off-by: Mike Nawrocki <michael.nawrocki@gtri.gatech.edu>
Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/smc911x.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c index ea7cea5f1b..1edc16ce44 100644 --- a/drivers/net/smc911x.c +++ b/drivers/net/smc911x.c @@ -541,7 +541,7 @@ static int smc911x_probe(struct device_d *dev) * forbidden while this bit isn't set. Try for 100ms */ ret = wait_on_timeout(100 * MSECOND, smc911x_reg_read(priv, PMT_CTRL) & PMT_CTRL_READY); - if (!ret) { + if (ret) { dev_err(dev, "Device not READY in 100ms aborting\n"); return -ENODEV; } |