diff options
| author | Ahmad Fatoum <ahmad@a3f.at> | 2021-04-10 12:49:11 +0200 |
|---|---|---|
| committer | Sascha Hauer <s.hauer@pengutronix.de> | 2021-04-13 09:19:05 +0200 |
| commit | e4ee908a4f124f36c92c7d8712882c201c9165b3 (patch) | |
| tree | da4b86a3bf4e65999e5b1ee9bb00f2de7fd55dae /drivers | |
| parent | a3ac0804351d7f21b1463df779ae8f9914a84430 (diff) | |
| download | barebox-e4ee908a4f124f36c92c7d8712882c201c9165b3.tar.gz barebox-e4ee908a4f124f36c92c7d8712882c201c9165b3.tar.xz | |
virtio: pci: remove inaccurate comment on 64-bit bar addr incompatibility
pci_iomap returns the bar base address, which can already be > 4G on
barebox. The comment originates from U-Boot, where indeed only the lower
32-bit are read. We don't have this limitation and qemu -M q35 places
bars for VirtIO devices at >= 0x8_0000_0000 and they worked correctly,
so drop the inaccurate comment.
Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
Link: https://lore.pengutronix.de/20210410104911.2079451-2-ahmad@a3f.at
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/virtio/virtio_pci_modern.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/drivers/virtio/virtio_pci_modern.c b/drivers/virtio/virtio_pci_modern.c index 180c14771a..d828bee69e 100644 --- a/drivers/virtio/virtio_pci_modern.c +++ b/drivers/virtio/virtio_pci_modern.c @@ -335,13 +335,6 @@ static void __iomem *virtio_pci_map_capability(struct pci_dev *dev, int off) offset = off + offsetof(struct virtio_pci_cap, offset); pci_read_config_dword(dev, offset, &offset); - /* - * TODO: adding 64-bit BAR support - * - * Per spec, the BAR is permitted to be either 32-bit or 64-bit. - * For simplicity, only read the BAR address as 32-bit. - */ - return pci_iomap(dev, bar) + offset; } |