diff options
| author | Enrico Jorns <ejo@pengutronix.de> | 2021-05-17 14:49:41 +0200 |
|---|---|---|
| committer | Sascha Hauer <s.hauer@pengutronix.de> | 2021-05-18 08:34:08 +0200 |
| commit | f873c7ff24973b7601415d53939f9375dcd1e418 (patch) | |
| tree | 88f2dc714d36bf8a6c7722dafc97cbd839cb40ba /drivers | |
| parent | dff43b5288835a05c2e8fac967c9e25166bb18cc (diff) | |
| download | barebox-f873c7ff24973b7601415d53939f9375dcd1e418.tar.gz barebox-f873c7ff24973b7601415d53939f9375dcd1e418.tar.xz | |
usb: dwc2: more precise and helpful message for dr_mode config issues
With the previous message I misunderstood that the 'configuration
mismatch' was caused by any entity forcing the dr_mode to
'host'/'device'.
The actual intention however is to tell the user that the selected
'dr_mode' does not match the capabilities provided by the controller or
the selected driver parts (USB_DWC2_HOST/USB_DWC2_GADGET).
The updated warning message attempts to reflect this more explicitly.
Also rename 'device' to 'peripheral' as it is named both in dtb and
in macros that way.
Signed-off-by: Enrico Jorns <ejo@pengutronix.de>
Acked-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Link: https://lore.barebox.org/20210517124941.31301-1-ejo@pengutronix.de
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/usb/dwc2/core.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c index 8a78d8199e..d0af25f4b4 100644 --- a/drivers/usb/dwc2/core.c +++ b/drivers/usb/dwc2/core.c @@ -672,8 +672,8 @@ int dwc2_get_dr_mode(struct dwc2 *dwc2) if (mode != dwc2->dr_mode) { dwc2_warn(dwc2, - "Configuration mismatch. dr_mode forced to %s\n", - mode == USB_DR_MODE_HOST ? "host" : "device"); + "Selected dr_mode not supported by controller/driver. Enforcing '%s' mode.\n", + mode == USB_DR_MODE_HOST ? "host" : "peripheral"); dwc2->dr_mode = mode; } |