diff options
| author | Sascha Hauer <s.hauer@pengutronix.de> | 2008-08-01 08:59:27 +0200 |
|---|---|---|
| committer | Sascha Hauer <s.hauer@pengutronix.de> | 2008-08-01 08:59:27 +0200 |
| commit | f295acb556da2b7a5e3b270ea8d34ea058fe7dc9 (patch) | |
| tree | a8e939e1133401ddd493f4f1fb0dfcd3257abd23 /fs/devfs.c | |
| parent | ec1b86784d4c08f8f0897161e142745080625698 (diff) | |
| download | barebox-f295acb556da2b7a5e3b270ea8d34ea058fe7dc9.tar.gz barebox-f295acb556da2b7a5e3b270ea8d34ea058fe7dc9.tar.xz | |
lseek: return -1 for errors and check for that return value
We cannot check for < 0 in lseek, otherwise we get problems with files > 0x7fffffff
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Diffstat (limited to 'fs/devfs.c')
| -rw-r--r-- | fs/devfs.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/devfs.c b/fs/devfs.c index 12abc1829d..cd9bed2676 100644 --- a/fs/devfs.c +++ b/fs/devfs.c @@ -47,11 +47,11 @@ static int devfs_write(struct device_d *_dev, FILE *f, const void *buf, size_t s static off_t devfs_lseek(struct device_d *_dev, FILE *f, off_t pos) { struct device_d *dev = f->inode; - int ret; + off_t ret; ret = dev_lseek(dev, pos); - if (ret >= 0) + if (ret != -1) f->pos = pos; return ret; |