summaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorSascha Hauer <s.hauer@pengutronix.de>2016-07-15 12:02:31 +0200
committerSascha Hauer <s.hauer@pengutronix.de>2016-07-22 11:59:49 +0200
commitfacda5a9cbf535e401be6667c231e5516125145f (patch)
treeef0a7b8c92052f6e818626feb9539d449c195c00 /fs
parent1f3b611979c28856af64148d2cef3555e6d12183 (diff)
downloadbarebox-facda5a9cbf535e401be6667c231e5516125145f.tar.gz
barebox-facda5a9cbf535e401be6667c231e5516125145f.tar.xz
fs: Check for correct open mode
Check that readonly openen files is not written to and writeonly files is not read from. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Diffstat (limited to 'fs')
-rw-r--r--fs/fs.c12
1 files changed, 11 insertions, 1 deletions
diff --git a/fs/fs.c b/fs/fs.c
index f63a2dde51..b7e7c63ffe 100644
--- a/fs/fs.c
+++ b/fs/fs.c
@@ -738,6 +738,11 @@ static ssize_t __read(FILE *f, void *buf, size_t count)
struct fs_driver_d *fsdrv;
int ret;
+ if ((f->flags & O_ACCMODE) == O_WRONLY) {
+ ret = -EBADF;
+ goto out;
+ }
+
fsdrv = f->fsdev->driver;
if (f->size != FILE_SIZE_STREAM && f->pos + count > f->size)
@@ -747,7 +752,7 @@ static ssize_t __read(FILE *f, void *buf, size_t count)
return 0;
ret = fsdrv->read(&f->fsdev->dev, f, buf, count);
-
+out:
if (ret < 0)
errno = -ret;
return ret;
@@ -796,6 +801,11 @@ static ssize_t __write(FILE *f, const void *buf, size_t count)
struct fs_driver_d *fsdrv;
int ret;
+ if (!(f->flags & O_ACCMODE)) {
+ ret = -EBADF;
+ goto out;
+ }
+
fsdrv = f->fsdev->driver;
if (f->size != FILE_SIZE_STREAM && f->pos + count > f->size) {
ret = fsdrv->truncate(&f->fsdev->dev, f, f->pos + count);