diff options
| author | Aleksander Morgado <aleksander@aleksander.es> | 2017-06-21 21:13:19 +0200 |
|---|---|---|
| committer | Sascha Hauer <s.hauer@pengutronix.de> | 2017-06-23 13:34:07 +0200 |
| commit | 9e5063aeebeddfcd31164ec0b952c7f48b9361bb (patch) | |
| tree | 0a4e4c346f57a588eeec512317c22a8af85b1a1b /lib | |
| parent | 9adcfb5c5318a4735511840883f6f4cd52e62699 (diff) | |
| download | barebox-9e5063aeebeddfcd31164ec0b952c7f48b9361bb.tar.gz barebox-9e5063aeebeddfcd31164ec0b952c7f48b9361bb.tar.xz | |
ratp: prefer using ratp_send_ack() in behaviour I1
Instead of manually constructing an ACK, use the ratp_send_ack()
method, which already does that properly.
Signed-off-by: Aleksander Morgado <aleksander@aleksander.es>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/ratp.c | 12 |
1 files changed, 3 insertions, 9 deletions
diff --git a/lib/ratp.c b/lib/ratp.c index 46a2b645c9..c7f3f41713 100644 --- a/lib/ratp.c +++ b/lib/ratp.c @@ -1330,7 +1330,6 @@ static int msg_recv(struct ratp_internal *ri, void *pkt) static int ratp_behaviour_i1(struct ratp_internal *ri, void *pkt) { struct ratp_header *hdr = pkt; - uint8_t control = 0; if (!ratp_has_data (hdr)) return 1; @@ -1341,15 +1340,10 @@ static int ratp_behaviour_i1(struct ratp_internal *ri, void *pkt) msg_recv(ri, pkt); - if (list_empty(&ri->sendmsg) || ri->sendmsg_current) { - control = ratp_set_sn(!ri->sn_sent) | - ratp_set_an(ri->sn_received + 1) | - RATP_CONTROL_ACK; - - ratp_send_hdr(ri, control); - } else { + if (list_empty(&ri->sendmsg) || ri->sendmsg_current) + ratp_send_ack(ri, hdr); + else ratp_send_next_data(ri); - } return 0; } |