summaryrefslogtreecommitdiffstats
path: root/lib
diff options
context:
space:
mode:
authorMasahiro Yamada <yamada.m@jp.panasonic.com>2015-01-29 19:43:06 +0900
committerSascha Hauer <s.hauer@pengutronix.de>2015-02-02 11:46:31 +0100
commit03dabc0fe4477954f4b37e3149e80ec643c0d03c (patch)
treeb4f02492bb29e1b34ad094526c3afa6f97e4879a /lib
parent2f025305aeb32c1a6c0b5d25bf1f655a931a8fad (diff)
downloadbarebox-03dabc0fe4477954f4b37e3149e80ec643c0d03c.tar.gz
barebox-03dabc0fe4477954f4b37e3149e80ec643c0d03c.tar.xz
param: add error check to __dev_add_param()
If strdup() fails with out-of-memory, __dev_add_param() should fail with -ENOMEM. (Note strdup() is always given with a non-NULL pointer. If the argument name is given with NULL, the system would already have crashed in the get_param_by_name() function.) Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Diffstat (limited to 'lib')
-rw-r--r--lib/parameter.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/lib/parameter.c b/lib/parameter.c
index 71262c48fd..865ad9f431 100644
--- a/lib/parameter.c
+++ b/lib/parameter.c
@@ -130,6 +130,10 @@ static int __dev_add_param(struct param_d *param, struct device_d *dev, const ch
if (get_param_by_name(dev, name))
return -EEXIST;
+ param->name = strdup(name);
+ if (!param->name)
+ return -ENOMEM;
+
if (set)
param->set = set;
else
@@ -139,7 +143,6 @@ static int __dev_add_param(struct param_d *param, struct device_d *dev, const ch
else
param->get = param_get_generic;
- param->name = strdup(name);
param->flags = flags;
param->dev = dev;
list_add_tail(&param->list, &dev->parameters);