diff options
author | Sascha Hauer <sha@pengutronix.de> | 2009-10-17 09:42:13 +0200 |
---|---|---|
committer | Sascha Hauer <s.hauer@pengutronix.de> | 2009-10-19 10:18:51 +0200 |
commit | 3701ed81ec431df96dc17b0143bdc9ffef072a6b (patch) | |
tree | 9b06ee35eb46417a6dee2467fb92537c7f5011e1 /net/ping.c | |
parent | feb58df760c5a0e517a2f92e08b45cf3aa0eabcb (diff) | |
download | barebox-3701ed81ec431df96dc17b0143bdc9ffef072a6b.tar.gz barebox-3701ed81ec431df96dc17b0143bdc9ffef072a6b.tar.xz |
ping: do not return -1 in command
Also, print usage if not enough arguments given.
Signed-off-by: Sascha Hauer <sha@pengutronix.de>
Diffstat (limited to 'net/ping.c')
-rw-r--r-- | net/ping.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/net/ping.c b/net/ping.c index 5909c31fe8..e9336b9578 100644 --- a/net/ping.c +++ b/net/ping.c @@ -83,12 +83,9 @@ PingHandler (uchar * pkt, unsigned dest, unsigned src, unsigned len) int do_ping (cmd_tbl_t *cmdtp, int argc, char *argv[]) { - if (argc < 2) - return -1; - - if (string_to_ip(argv[1], &NetPingIP)) { + if (argc < 2 || string_to_ip(argv[1], &NetPingIP)) { printf ("Usage:\n%s\n", cmdtp->usage); - return -1; + return 1; } if (NetLoopInit(PING) < 0) |