summaryrefslogtreecommitdiffstats
path: root/fs
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch 'for-next/misc'Sascha Hauer2021-02-221-6/+36
|\
| * fs: increase reference count for backing store when loop mountingAhmad Fatoum2021-02-161-6/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The VFS layer already increase the mount reference count for the mount point. This means e.g. following sequence is well-behaving: mkdir -p /mnt/disk0.0/media mount -o loop backing.squashfs /mnt/disk0.0/media umount /mnt/disk0.0 barebox will do the right thing and report umount: Device or resource busy However the reference count of the file where backing.squashfs comes from is not incremented on mount with the effect that following sequence crashes: mkdir -p /media mount -o loop /mnt/disk0.0/backing.squashfs /media umount /mnt/disk0.0 # should've returned EBUSY umount /media Fix this by touching the backing store's mount reference count when loop mounting and unmounting. Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
* | Merge branch 'for-next/ext4'Sascha Hauer2021-02-226-63/+49
|\ \
| * | fs: ext4: support files exceeding 4GAhmad Fatoum2021-02-183-2/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ext4 redefines directory ACL to hold the most-significant 32-bit of the inode size for regular files. For directories, it can either be ACL or, when using largedir, the most-significant 32-bit of the directory size. Adapt the code take these upper 32-bit into consideration for determining regular file size. For directories, behavior remains unchanged as we neither support ACLs nor >= 4G directories Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
| * | fs: ext4: use sector_t and loff_t where appropriateAhmad Fatoum2021-02-185-31/+38
| | | | | | | | | | | | | | | | | | | | | | | | While the block API now supports 64-bit LBAs, file systems like ext4 still use 31- and 32-bit integers at a couple of places. Fix them up. Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
| * | fs: ext4: ext4fs.h: remove unused struct members of ext_filesystemAhmad Fatoum2021-02-181-29/+0
| | | | | | | | | | | | | | | | | | | | | | | | struct ext_filesystem is for in-memory bookkeeping but most of it is unused by barebox and just takes up space. Drop the unused members. Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
| * | ext4: ext_common.h: drop declaration of never-defined part_offsetAhmad Fatoum2021-02-181-1/+0
| |/ | | | | | | | | | | | | | | part_offset is a left-over from the U-Boot port and unused anywhere. Drop it. Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
* / printk: port over Linux print_hex_dump_bytes/print_hex_dump_debugAhmad Fatoum2021-02-041-1/+1
|/ | | | | | | | | print_hex_dump in barebox always prints a hex dump. Most users use it for debugging though, so import Linux helpers to do so to cut down on the #ifdef DEBUG. Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
* Merge branch 'for-next/misc'Sascha Hauer2020-12-111-1/+1
|\
| * fs: introduce unsetenv() to prepare for changing setenv(var, "") behaviorAhmad Fatoum2020-11-231-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, we treat setenv(var, "") and setenv(var, NULL) the same and delete var, which is surprising and leads to subtle quirks: - setenv(var, "") is specified by POSIX to set var to an empty string, but barebox uses it to delete variables - nv.user= calls nv_set with NULL parameter, but nv user="" doesn't Make the API more POSIX-like by providing unsetenv with the expected semantics. Most user code can then use unsetenv without worrying about whether "" or NULL is the magic deletion value. Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
* | ubifs: remove wrong assertionSascha Hauer2020-12-101-1/+6
|/ | | | | | | | | | | In barebox copy_znode() doesn't make a copy of the znode, We are limited to readonly support, so copy_znode() returns the original node. tnc_delete() expects a znode to be dirty and has an assertion for this. In a normal r/w implementation this is correct, but not in barebox, so drop the assertion. Instead of removing it just comment it out to make sure it won't be added again with the next ubifs kernel synchronisation. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
* nfs: check return value of various rpc callsUwe Kleine-König2020-11-091-11/+113
| | | | | | | | | | | | | | | Check more carefully for failing requests. This improves the error message when trying to mount a non-exported nfs directory from: nfs_mount_req: file handle too big: 44831 to ERROR: NFS: Mounting failed: Permission denied . This also fixes an out-of-bounds access as the filehandle size (44831 above) is read from just after the network packet in the error case. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
* Merge branch 'for-next/percent_pe' into masterSascha Hauer2020-10-141-2/+1
|\
| * vsprintf: retire strerrorp in favor of %peAhmad Fatoum2020-09-291-2/+1
| | | | | | | | | | | | | | | | | | strerrorp() is only used along with printf. We now have a format specifier for printing error pointers directly, so use that and remove strerrorp. Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
* | Merge branch 'for-next/magicvar-unique-id' into masterSascha Hauer2020-10-141-5/+4
|\ \
| * | magicvar: Replace BAREBOX_MAGICVAR_NAMED with BAREBOX_MAGICVARSascha Hauer2020-10-021-5/+4
| |/ | | | | | | | | | | | | | | BAREBOX_MAGICVAR now generates a unique identifier automatically, so we can convert users of BAREBOX_MAGICVAR_NAMED to the simpler BAREBOX_MAGICVAR macro. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
* / fs: squashfs: remove dead stores for xattr_idAhmad Fatoum2020-10-021-6/+0
|/ | | | | | | | | barebox doesn't do extended attributes in SquashFS. Remove the left-over xattr_id that's never read. Reported-by: clang-analyzer-10 Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
* Merge branch 'for-next/net' into masterSascha Hauer2020-09-251-0/+34
|\
| * fs: Warn when filesystem operations are called from a pollerSascha Hauer2020-08-191-0/+34
| | | | | | | | | | | | | | | | | | Filesystem operations possibly call into arbitrary devices, so shouldn't be used from a poller. This patch sprinkles some WARN_ONCE() when this happens. One exception is when the file which is accessed is on ramfs which doesn't have any dependencies to devices. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
* | fs: Fix use after freeSascha Hauer2020-09-141-3/+3
| | | | | | | | | | | | | | | | | | | | In case of the fs mounted to '/' the root dentry of the mounted filesystem is the place where it's mounted itself, so sb->s_root is the same as fsdev->vfsmount.mountpoint. In that case make sure we only access it before it has been killed in dentry_delete_subtree(). Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
* | fs: Drop unnecessary dput()Sascha Hauer2020-09-141-1/+0
| | | | | | | | | | | | | | Calling dput() on the root dentry during unmount time is unnecessary, the dentry will be removed later in dentry_delete_subtree() anyway. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
* | fs: don't free device in remove callbackAhmad Fatoum2020-09-141-2/+9
| | | | | | | | | | | | | | | | | | | | | | The probe doesn't allocate the device, so remove shouldn't free it either. This fixes a use-after-free on barebox shutdown: Iterating over the list of devices requires that remove callbacks don't remove the devices. This happened to work so far, because apparently not much new allocations are going on during barebox shutdown, but let's do it right. Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
* | fs: Use iget_locked() rather than squashfs specific functionSascha Hauer2020-08-202-18/+1
| | | | | | | | | | | | | | | | | | | | | | | | Use iget_locked() to let the core allocate the inode. This properly initializes all fields in the new inode, especially it adds the new inode to the list of all inodes for the filesystem. This prevents a NULL pointer derefence when iput() removes the inode from that list. This fixes squashfs support which is broken since 43902e5763 ("fs: free inodes we no longer need") Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
* | fs: squashfs: Do not free root inodeSascha Hauer2020-08-201-1/+0
| | | | | | | | | | | | | | With inode reference counting in place the core will free the root inode, so do not free it in the squashfs code. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
* | fs: squashfs: set s_op in timeSascha Hauer2020-08-201-2/+1
|/ | | | | | | When calling squashfs_mount() s_op needs to be set already, otherwise calling alloc_inode() yields in a NULL pointer derefence. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
* Merge branch 'for-next/ramfs'Sascha Hauer2020-07-276-164/+228
|\
| * fs: ramfs: Implement memmapSascha Hauer2020-07-051-0/+20
| | | | | | | | | | | | | | When an inode only has a single chunk then we can support memmap for it. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
| * fs: ramfs: Use dynamically sized chunksSascha Hauer2020-07-051-148/+159
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This changes the way ramfs stores its data. So far we used equally sized chunks, this patch changes it to use chunks in a size that fits our needs. The chunks are always allocated in the size they are needed for the current truncation. Only if we fail to allocate all desired memory at once we fall back to allocating smaller chunks. Together with using the generic list implementation this results in smaller code and has the advantage that many image files end up being contiguously in memory and thus we can provide a memmap for them. Files will end up contiguously in memory when they are first created, then truncated to the final size and then filled up with data. This is something which is normally easily achievable when desired. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
| * fs: ramfs: Drop dead codeSascha Hauer2020-07-051-14/+0
| | | | | | | | Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
| * fs: ramfs: Return -ENOSPCSascha Hauer2020-07-051-2/+2
| | | | | | | | | | | | | | When ramfs fails to allocate more memory then returning -ENOSPC is more appropriate then -ENOMEM. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
| * fs: free inodes we no longer needSascha Hauer2020-07-051-3/+5
| | | | | | | | | | | | | | | | So far we freed the no longer needed inodes only at unmount time. Let's trust our reference counting a bit more and free them once the reference counter hits zero. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
| * fs: Make iput() accept NULL pointersSascha Hauer2020-07-051-0/+3
| | | | | | | | | | | | | | Let iput() accept NULL pointers so that users do not have to test for it. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
| * fs: Add destroy_inode callbacks to filesystemsSascha Hauer2020-07-055-1/+43
| | | | | | | | | | | | | | | | | | | | | | Several filesystems rely on the default function which frees the struct inode * rather than the filesystem specific inode which the inode is embedded in. This works because the inode is the first element in the filesystem specific inode. Let's not depend on this behaviour and for clarity add the destroy_inode callbacks to all filesystems. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
* | fs: fat: extend for in-PBL supportAhmad Fatoum2020-07-119-83/+175
|/ | | | | | | | | | | The AT91 BootROM loads a boot.bin file from the first FAT partition into SRAM, when booting from MMC. To avoid the need for two barebox configurations for each of the bootloader stages, add PBL support for reading from FAT. This way each stage need only have a different PBL entry point. Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
* Merge branch 'for-next/misc'Sascha Hauer2020-05-1410-30/+0
|\
| * treewide: remove references to CREDITSUwe Kleine-König2020-04-2710-30/+0
| | | | | | | | | | | | | | | | The CREDITS file was removed from barebox in 2015 by commit 6570288f2d97 ("Remove the CREDITS file"). Remove references to it from several files. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
* | fs: Fix inode size setting in ftruncateSascha Hauer2020-05-051-0/+1
|/ | | | | | | When changing a file size the size of the corresponding inode has to be changed as well. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
* nfs: Do not allow to abortSascha Hauer2020-03-301-3/+0
| | | | | | | | | | | | | | When ctrl-c is pressed then ctrlc() will return true until ctrlc_handled() is called. This means that once ctrl-c is pressed every NFS operation will fail until the upper layer calls ctrlc_handled(). When for example we are doing a 'ls -l' on an NFS directory then after a ctrl-c press not the 'ls -l' aborts, but instead the retrieving of the directory entries which is not what we want. Simply do not call ctrlc() in the fs layer. the NFS timeout is 2 seconds which we have to wait until we have a chance to abort. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
* fs: nfs: don't maintain nfs dentries in dcacheSascha Hauer2020-03-301-0/+1
| | | | | | | nfs dentries may change underneath barebox, so do not maintain them in the dcache. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
* nfs: queue received packetsSascha Hauer2020-03-301-23/+29
| | | | | | | | | It may happen that we receive more than one RPC packet before we come along to check the result. Instead of handling just a single received packet and possibly overwriting the last one queue the received RPC packets. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
* nfs: Fix polling for packetsSascha Hauer2020-03-301-2/+5
| | | | | | | | | It can happen that the first packet we receive is not the desired one. In this case we have to poll for further packets. set nfs_state back to STATE_START before polling for more packets, otherwise we check the same packet again and again. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
* nfs: Fix rpc_check_reply() return value for stale packetsSascha Hauer2020-03-301-7/+2
| | | | | | | | | | | When we receive a packet with the previous rpc_id then we have the comment "stale packet, wait a bit longer", but that's not what the code does. rpc_check_reply() returns 0 in this case and the caller then interprets the packet as valid. Always return -EAGAIN for invalid rpc_ids. This lets the caller ignore the packets as intented. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
* nfs: remove unnecessary checkSascha Hauer2020-03-301-3/+0
| | | | | | In rpc_check_reply() pkt is never NULL, drop the unnecessary patch. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
* nfs: Add missing freeSascha Hauer2020-03-301-0/+1
| | | | | | Add forgotten packet free in error path. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
* nfs: Add function to free packetsSascha Hauer2020-03-301-11/+16
| | | | | | | | Add to function to free packets rather than freeing them directly. We will introduce received packet qeueuing with one of the next patches, this patch is meant to make it better readable. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
* Merge branch 'for-next/block'Sascha Hauer2020-03-182-0/+46
|\
| * cdev: Add discard_range hookSascha Hauer2020-02-141-0/+21
| | | | | | | | | | | | | | To pass though discard_range() to the underlying drivers add a discard_range hook to struct cdev_operations. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
| * fs: Introduce discard_range()Sascha Hauer2020-02-141-0/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | discard_range() is a way to tell the lower layers that we are no longer interested in a data range of a file, so that the lower layers can discard the underlying data if desired. This is mainly designed to bypass the deficiencies of our block layer. We cache the block data in chunks of multiple KiB (16 currently) if we fall into the block layer with write requests smaller than that we have to read/modify/write a chunk. With the help of discard_range() code writing files to a raw block device can now discard the range the file will be written to. The block layer then no longer has to read the chunks first that are inside the discard range. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
* | fs: jffs2: add initial support for reading jffs2Steffen Trumtrar2020-02-1028-0/+8459
|/ | | | | | | | | | | | | | | | | | | | | Import the jffs2 filesystem code from Linux v5.5-rc1 and convert it to work with barebox. Writing is *not* supported. Testing was done with a n25q256a-compatible QuadSPI chip on a SoCFPGA-based Socrates board. Testing was done with a combination of: user@somelinuxhost: mkfs.jffs2 --eraseblock=4 -d fs/jffs2/ -o jffs2.img root@target:~ flash_erase -j /dev/mtd5 0 0 root@target:~ dd if=jffs2.img of=/dev/mtd5 barebox@EBV SOCrates:/ mount /dev/mtd0.data (...) mounted /dev/mtd0.data on /mnt/mtd0.data Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
* pstore: ramoops: use correct format specifier for size_t variablesLucas Stach2019-12-021-4/+4
| | | | | Signed-off-by: Lucas Stach <l.stach@pengutronix.de> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>