summaryrefslogtreecommitdiffstats
path: root/scripts/checkpatch.pl
Commit message (Collapse)AuthorAgeFilesLines
* checkpatch.pl: check for #if 0/#if 1Antony Pavlov2018-12-061-3/+8
| | | | | | | | | | | The #if 0 or #if 1 is used to toggle features. Warn if #if 0 or #if 1 is present and suggest that they can be removed. Based on 60f890105547f7a4 ("checkpatch: check for #if 0/#if 1") Linux kernel commit. Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
* checkpatch.pl: use SPDX tagAntony Pavlov2018-12-061-1/+3
| | | | | | | | | | Also add Joe's copyright. Based on Linux kernel commit 882ea1d64eb3956 ("scripts: use SPDX tag in get_maintainer and checkpatch"). Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
* checkpatch.pl: check for common memset parameter issues against statementsAntony Pavlov2018-12-061-0/+22
| | | | | | | | | | Based on these Linux kernel commits > 309c00c73f053a90 checkpatch: warn about memset with swapped arguments > 554e165cf32610ec checkpatch: check for common memset parameter issues against statments Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
* checkpatch.pl: add ability to ignore various messagesAntony Pavlov2018-12-061-139/+336
| | | | | | | | | | | | | Based on commit 000d1cc1829f938c ("checkpatch.pl: add ability to ignore various messages") from Linux kernel. This simplifies current linux kernel checkpatch.pl commit adoption for barebox due to conversion of 1-argument ERROR($1), WARN($1) and CHK($1) subs into 2-argument ERROR($1, $2), WARN($1, $2) and CHK($1, $2) subs. Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
* checkpatch: don't check TODO file presenceAntony Pavlov2018-09-181-1/+1
| | | | | | | | | | The commit b3baf2d86149 ("TODO: remove unused file") drops the TODO file. Alas scripts/checkpatch.pl checks TODO file presence in top_of_kernel_tree(). Without TODO checkpatch.pl exits with 'Must be run from the top-level dir. of a kernel tree'. Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
* checkpatch: fix another left brace warningGeyslan G. Bem2017-01-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | This patch escapes a regex that uses left brace. Using checkpatch.pl with Perl 5.22.0 generates the warning: "Unescaped left brace in regex is deprecated, passed through in regex;" Comment from regcomp.c in Perl source: "Currently we don't warn when the lbrace is at the start of a construct. This catches it in the middle of a literal string, or when it's the first thing after something like "\b"." This works as a complement to 4e5d56bd ("checkpatch: fix left brace warning"). Signed-off-by: Geyslan G. Bem <geyslan@gmail.com> Signed-off-by: Joe Perches <joe@perches.com> Suggested-by: Peter Senna Tschudin <peter.senna@gmail.com> Cc: Eddie Kovsky <ewk@edkovsky.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
* checkpatch: fix left brace warningAlexander Aring2015-10-271-4/+4
| | | | | | | | | | | | | | | | | | | Running checkpatch with perl version 5.22 occur the following warnings: Unescaped left brace in regex is deprecated, ... checkpatch.pl line 2017. Unescaped left brace in regex is deprecated, ... checkpatch.pl line 2267. Unescaped left brace in regex is deprecated, ... checkpatch.pl line 2268. ... lot of weird things ... )\(.*\).*\s{ <-- HERE / at ./scripts/checkpatch.pl line 2016. This patch fix these warning, an similar commit was done in linux kernel commit: 4e5d56bdf892e18832a6540b63ebf709966bce2a ("checkpatch: fix left brace warning"). Signed-off-by: Alexander Aring <alex.aring@gmail.com> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
* checkpatch: add DT compatible string documentation checksAntony Pavlov2015-04-281-0/+35
| | | | | | | | | | | | | | | | | | | | | | | | | This adds a simple check that any compatible strings in DeviceTree dts files are present in Documentation/devicetree/bindings and in dts/Bindings/. Vendor prefixes are also checked for existing in vendor-prefixes.txt. This code is based on linux v4.0-rc6 checkpatch.pl dt-checking code by Rob Herring & Florian Vaussard: Rob Herring (2): checkpatch: add DT compatible string documentation checks checkpatch: fix wildcard DT compatible string checking Florian Vaussard (3): checkpatch: fix spurious vendor compatible warnings checkpatch: check compatible strings in .c and .h too checkpatch: improve the compatible vendor match Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com> Cc: Rob Herring <robh@kernel.org> Cc: Florian Vaussard <florian.vaussard@epfl.ch> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
* scripts/checkpatch.pl: don't search for CREDITS when checking ↵Antony Pavlov2015-01-201-1/+1
| | | | | | | | | | | | | | | | | | | top_of_kernel_tree() The CREDITS file is removed in the commit commit 6570288f2d97d3a3dceb3e631b4e4f4305352dc8 Author: Masahiro Yamada <yamada.m@jp.panasonic.com> Date: Tue Jan 13 14:27:07 2015 +0900 Remove the CREDITS file But checkpatch.pl still trying to check it presence. There is not such CREDITS file and checkpatch.pl exits with 'Must be run from the top-level dir. of a kernel tree' message. Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
* checkpatch.pl: check for the FSF mailing addressAntony Pavlov2014-09-121-0/+10
| | | | | | | This check code is imported from Linux v3.16 checkpatch.pl. Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
* scripts/checkpatch.pl: don't search for Doxyfile when checking ↵Antony Pavlov2014-07-221-1/+1
| | | | | | | | | | | | | | | | | | | top_of_kernel_tree() Doxygen documentation is removed in the commit commit 98360be0fefd58bf27df03c47d887dd676a31d73 Author: Sascha Hauer <s.hauer@pengutronix.de> Date: Tue Jun 17 10:27:03 2014 +0200 Documentation: remove doxygen documentation But checkpatch.pl still trying to check 'Doxyfile' presence. There is not such 'Doxyfile' and checkpatch.pl exits with 'Must be run from the top-level dir. of a kernel tree' message. Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
* scripts: allow lines longer than 80 cols with printf() in checkpatchThomas Petazzoni2013-05-061-1/+1
| | | | | | | | | The checkpatch.pl script is also used to validate user-space code in the scripts/ directory, so it should allow printf() lines to be longer than 80 columns. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
* scripts/checkpatch.pl: reset rpt_cleaners warningsTeresa Gámez2012-07-251-0/+1
| | | | | | | | | | | | | | | When running checkpatch against multiple patches and one of them has a whitespace issue, all following patches will contain the same note, even if they are ok. This patch is taken from the linux kernel: scripts/checkpatch.pl: reset rpt_cleaners warnings b0781216e7bff68aca2fbcd275b4db7531d1e22f Written by Mike Frysinger <vapier@gentoo.org> Signed-off-by: Teresa Gámez <t.gamez@phytec.de> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
* scripts: Adapt checkpatch.pl for barebox.Marek Belisko2010-11-291-3/+3
| | | | | | | | Add directories from root of barebox to top_of_kernel_tree() function for usage of script without additional parameters. Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
* scripts: Add checkpatch.pl script.Marek Belisko2010-11-291-0/+2950
Overtake script checkpatch.pl from kernel source. Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>