From 3b1ac08954d4518e019331fb34ba9b0677055145 Mon Sep 17 00:00:00 2001 From: Michael Tretter Date: Thu, 19 Aug 2021 10:12:49 +0200 Subject: firmware: zynqmp-fpga: initialize flags at function start The ZYNQMP_FPGA_BIT_ONLY_BIN flag is always set when programming the FPGA. Simplify the code by initializing the flags with ZYNQMP_FPGA_BIT_ONLY_BIN already set. Signed-off-by: Michael Tretter Link: https://lore.barebox.org/20210819081251.726840-2-m.tretter@pengutronix.de Signed-off-by: Sascha Hauer --- drivers/firmware/zynqmp-fpga.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/firmware/zynqmp-fpga.c b/drivers/firmware/zynqmp-fpga.c index 0fc229bfd3..736d1950fa 100644 --- a/drivers/firmware/zynqmp-fpga.c +++ b/drivers/firmware/zynqmp-fpga.c @@ -205,7 +205,7 @@ static int fpgamgr_program_finish(struct firmware_handler *fh) enum xilinx_byte_order byte_order; u64 addr; int status = 0; - u8 flags = 0; + u8 flags = ZYNQMP_FPGA_BIT_ONLY_BIN; if (!mgr->buf) { status = -ENOBUFS; @@ -259,9 +259,6 @@ static int fpgamgr_program_finish(struct firmware_handler *fh) addr = (u64)buf_aligned; - /* we do not provide a header */ - flags |= ZYNQMP_FPGA_BIT_ONLY_BIN; - if (!(mgr->features & ZYNQMP_PM_FEATURE_SIZE_NOT_NEEDED) && buf_size) { status = mgr->eemi_ops->fpga_load(addr, (u32)(uintptr_t)buf_size, -- cgit v1.2.3