From 3f2df4e92a8b68760e8e4f3c481cce88bd0bd082 Mon Sep 17 00:00:00 2001 From: Andrey Smirnov Date: Wed, 15 Nov 2017 14:27:53 -0800 Subject: fs: Fix can_lseek_backward() To quote corresponding man page: "... Upon successful completion, lseek() returns the resulting offset location as measured in bytes from the beginning of the file." Which for lseek(fd, 0, SEEK_SET) would be 0, so returning 'ret' as final step of the function would mean it'd never return anything but 0 as well. Change the code to explicitly return '1' to fix the problem. Fixes: 7c3f8d366 ("uimage: fix: add can_lseek_backward and use in uimage_open") Cc: Michael Grzeschik Signed-off-by: Andrey Smirnov Signed-off-by: Sascha Hauer --- include/fs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/fs.h b/include/fs.h index f8a3b8bda4..5c5fff8701 100644 --- a/include/fs.h +++ b/include/fs.h @@ -117,7 +117,7 @@ static inline int can_lseek_backward(int fd) if (ret < 0) return 0; - return ret; + return 1; } #define drv_to_fs_driver(d) container_of(d, struct fs_driver_d, drv) -- cgit v1.2.3