From 45a280f0b6cb32936c943f0904738ed13066ceca Mon Sep 17 00:00:00 2001 From: Sascha Hauer Date: Wed, 12 Sep 2018 09:04:37 +0200 Subject: fs: devfs: Create device files as character devices Without this files in /dev/ appear as regular files. copy_file() stumbles upon this as it tries a truncate() on that files which then fails. Create the files as character devices so that copy_file() works as expected. Fixes: 9137c41915 ("fs: devfs: Switch to dentry cache implementation") Signed-off-by: Sascha Hauer Tested-by: Giorgio Dal Molin --- fs/devfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/devfs.c b/fs/devfs.c index 5d0bb2c674..84c619f1ed 100644 --- a/fs/devfs.c +++ b/fs/devfs.c @@ -226,7 +226,7 @@ static struct inode *devfs_get_inode(struct super_block *sb, const struct inode switch (mode & S_IFMT) { default: return NULL; - case S_IFREG: + case S_IFCHR: inode->i_op = &devfs_file_inode_operations; inode->i_fop = &devfs_file_operations; break; @@ -251,7 +251,7 @@ static struct dentry *devfs_lookup(struct inode *dir, struct dentry *dentry, if (!cdev) return ERR_PTR(-ENOENT); - inode = devfs_get_inode(dir->i_sb, dir, S_IFREG | S_IRWXUGO); + inode = devfs_get_inode(dir->i_sb, dir, S_IFCHR | S_IRWXUGO); if (!inode) return ERR_PTR(-ENOMEM); -- cgit v1.2.3