From 645320b94aaa0f478d31809673df6f83964c5292 Mon Sep 17 00:00:00 2001 From: Andrey Smirnov Date: Wed, 6 Jan 2016 22:17:32 -0800 Subject: rtc-lib: Check tm_wday for validity in rtc_valid_tm() RTC drivers rely on rtc_valid_tm() in order to make sure that no bogus values from uninitialized HW registers get passed to the uppper layers. A somewhat contrived way to reproduce this problem with DS1307 RTC would be to do the following: > i2c_write -b -a -r 3 0x00 > hwclock Signed-off-by: Andrey Smirnov Signed-off-by: Sascha Hauer --- drivers/rtc/rtc-lib.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/rtc/rtc-lib.c b/drivers/rtc/rtc-lib.c index 1b23458a57..83d80455da 100644 --- a/drivers/rtc/rtc-lib.c +++ b/drivers/rtc/rtc-lib.c @@ -90,6 +90,8 @@ int rtc_valid_tm(struct rtc_time *tm) { if (tm->tm_year < 70 || ((unsigned)tm->tm_mon) >= 12 + || tm->tm_wday < 0 + || tm->tm_wday > 6 || tm->tm_mday < 1 || tm->tm_mday > rtc_month_days(tm->tm_mon, tm->tm_year + 1900) || ((unsigned)tm->tm_hour) >= 24 -- cgit v1.2.3