From bddbf8dfc9ffd286ba7d19502e21f47c61df8fe2 Mon Sep 17 00:00:00 2001 From: Ahmad Fatoum Date: Mon, 8 Nov 2021 08:52:06 +0100 Subject: pinctrl: Rockchip: abort probe on lack of aliases The driver depends on the existence of aliases and will read out-of-bounds if they are missing for a node. Make failure graceful by aborting before that happens. Signed-off-by: Ahmad Fatoum Link: https://lore.barebox.org/20211108075209.2366770-6-a.fatoum@pengutronix.de Signed-off-by: Sascha Hauer --- drivers/pinctrl/pinctrl-rockchip.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c index 9b832c97d6..e73e378490 100644 --- a/drivers/pinctrl/pinctrl-rockchip.c +++ b/drivers/pinctrl/pinctrl-rockchip.c @@ -342,6 +342,9 @@ static int rockchip_gpio_probe(struct device_d *dev) int ret, bankno; bankno = of_alias_get_id(dev->device_node, "gpio"); + if (bankno < 0) + return bankno; + bank = &ctrl->pin_banks[bankno]; gpio = &bank->bgpio_chip.gc; -- cgit v1.2.3