From 435ec2679e4d1bd500b6f1b357392d16e0592f28 Mon Sep 17 00:00:00 2001 From: Lucas Stach Date: Wed, 6 Jul 2016 21:32:48 +0200 Subject: commands: menu: check return pointer properly The called functions return error codes encoded in the pointer, so the NULL check will never be true. Signed-off-by: Lucas Stach Signed-off-by: Sascha Hauer --- commands/menu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'commands/menu.c') diff --git a/commands/menu.c b/commands/menu.c index 9ec2d579b7..e1079fd51e 100644 --- a/commands/menu.c +++ b/commands/menu.c @@ -83,7 +83,7 @@ static int do_menu_entry_add(struct cmd_menu *cm) else me = menu_add_command_entry(m, cm->description, cm->command, cm->type); - if (!me) + if (IS_ERR(me)) return PTR_ERR(me); me->box_state = cm->box_state > 0 ? 1 : 0; -- cgit v1.2.3