From f1f532084a6e9ee8225f047353999b459455df7e Mon Sep 17 00:00:00 2001 From: Holger Schurig Date: Tue, 13 May 2014 10:28:42 +0200 Subject: commands: harmonize in-barebox documentation This patch does probably too much, but it's hard (and very cumbersome/time consuming) to break it out. What is does is this: * each command has one short description, e.g. "list MUX configuration" * made sure the short descriptions start lowercase * each command has one usage. That string contains just the options, e.g. "[-npn]". It's not part of the long help text. * that is, it doesn't say "[OPTIONS]" anymore, every usable option is listed by character in this (short) option string (the long description is in the long help text, as before) * help texts have been reworked, to make them - sometimes smaller - sometimes describe the options better - more often present themselves in a nicer format * all long help texts are now created with BUSYBOX_CMD_HELP_ macros, no more 'static const __maybe_unused char cmd_foobar_help[]' * made sure the long help texts starts uppercase * because cmdtp->name and cmdtp->opts together provide the new usage, all "Usage: foobar" texts have been removed from the long help texts * BUSYBOX_CMD_HELP_TEXT() provides the trailing newline by itself, this is nicer in the source code * BUSYBOX_CMD_HELP_OPT() provides the trailing newline by itself * made sure no line gets longer than 77 characters * delibertely renamed cmdtp->usage, so that we can get compile-time errors (e.g. in out-of-tree modules that use register_command() * the 'help' command can now always emit the usage, even without compiled long help texts * 'help -v' gives a list of commands with their short description, this is similar like the old "help" command before my patchset * 'help -a' gives out help of all commands Signed-off-by: Holger Schurig Signed-off-by: Sascha Hauer --- commands/nandtest.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) (limited to 'commands/nandtest.c') diff --git a/commands/nandtest.c b/commands/nandtest.c index 8af75ba67d..ee7725d47e 100644 --- a/commands/nandtest.c +++ b/commands/nandtest.c @@ -336,19 +336,20 @@ err: return 1; } -/* String for usage of nandtest */ -static const __maybe_unused char cmd_nandtest_help[] = -"Usage: nandtest [OPTION] \n" - " -t, Really do a nandtest on device.\n" - " -m, Mark blocks bad if they appear so.\n" - " -s , Supply random seed.\n" - " -i , Number of iterations.\n" - " -o , Start offset on flash.\n" - " -l , Length of flash to test.\n"; +BAREBOX_CMD_HELP_START(nandtest) +BAREBOX_CMD_HELP_TEXT("Options:") +BAREBOX_CMD_HELP_OPT ("-t", "Really do a nandtest on device") +BAREBOX_CMD_HELP_OPT ("-m", "Mark blocks bad if they appear so") +BAREBOX_CMD_HELP_OPT ("-s SEED", "supply random seed") +BAREBOX_CMD_HELP_OPT ("-i ITERATIONS", "nNumber of iterations") +BAREBOX_CMD_HELP_OPT ("-o OFFS", "start offset on flash") +BAREBOX_CMD_HELP_OPT ("-l LEN", "length of flash to test") +BAREBOX_CMD_HELP_END BAREBOX_CMD_START(nandtest) .cmd = do_nandtest, - .usage = "NAND Test", + BAREBOX_CMD_DESC("NAND flash memory test") + BAREBOX_CMD_OPTS("[-tmsiol] NANDDEVICE") BAREBOX_CMD_GROUP(CMD_GRP_HWMANIP) BAREBOX_CMD_HELP(cmd_nandtest_help) BAREBOX_CMD_END -- cgit v1.2.3