From 5d6c8ac4b41b66cc2785d4e4e82397a5c7e66336 Mon Sep 17 00:00:00 2001 From: Sascha Hauer Date: Tue, 26 Feb 2013 19:54:10 +0100 Subject: of_property command: Fix crash with empty property value the of_property command crashes when an empty property value was given. This is because xrealloc is called with a length argument of 0. Fix this. Signed-off-by: Sascha Hauer --- commands/of_property.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) (limited to 'commands/of_property.c') diff --git a/commands/of_property.c b/commands/of_property.c index bd9ff72fbc..1567a0f164 100644 --- a/commands/of_property.c +++ b/commands/of_property.c @@ -255,9 +255,15 @@ static int do_of_property(int argc, char *argv[]) if (pp) { free(pp->value); + /* limit property data to the actual size */ - data = xrealloc(data, len); - pp->value = data; + if (len) { + pp->value = xrealloc(data, len); + } else { + pp->value = NULL; + free(data); + } + pp->length = len; } else { pp = of_new_property(node, propname, data, len); -- cgit v1.2.3