From a2b3a25417593e97500cd746f0632d36edfac1a5 Mon Sep 17 00:00:00 2001 From: Trent Piepho Date: Fri, 4 Dec 2015 19:24:19 +0000 Subject: ARM: Remove do_execute and thumb2_execute In commit 104a6a7ccfb7928ca5dc28c8cbe0ea231ffc45ee support was added for Thumb2. It added do_execute() as a way to provide arch dependent calling veneers for use in "go" and thumb2_execute() as the thumb2 to arm veneer. But thumb2_execute() isn't necessary as gcc generates a proper calling sequence from a standard function pointer call. Thumb2 barebox is compiled with the AAPCS ABI which requires this. It also had a bug and didn't pass the arguments properly, but code execute via "go" rarely uses arguments so this wasn't very noticeable. Since thumb2 was always the only user of do_execute(), go ahead and delete that too. Signed-off-by: Trent Piepho Signed-off-by: Sascha Hauer --- commands/go.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) (limited to 'commands') diff --git a/commands/go.c b/commands/go.c index f25db48ca2..fb319b320c 100644 --- a/commands/go.c +++ b/commands/go.c @@ -60,10 +60,7 @@ static int do_go(int argc, char *argv[]) shutdown_barebox(); - if (do_execute) - do_execute(func, argc - 1, &argv[1]); - else - func(argc - 1, &argv[1]); + func(argc - 1, &argv[1]); /* * The application returned. Since we have shutdown barebox and -- cgit v1.2.3