From ff16f98a42801dbedf3ca9a2a2e88236cce9f672 Mon Sep 17 00:00:00 2001 From: Uwe Kleine-König Date: Mon, 6 Aug 2018 21:14:18 +0200 Subject: of_node: clarify help text and do stricter commandline parsing MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit To create an oftree node /path/node I tried after reading the help text of of_node: of_node -c /path node similar to the syntax of of_property. This didnt result in any output but still failed to do what I meant. So clarify the help text to not suggest there are two parameters and return an usage error if still two (or more) names are passed. Signed-off-by: Uwe Kleine-König Signed-off-by: Sascha Hauer --- commands/of_node.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'commands') diff --git a/commands/of_node.c b/commands/of_node.c index 29cc371dd2..28c4357c5d 100644 --- a/commands/of_node.c +++ b/commands/of_node.c @@ -107,11 +107,10 @@ static int do_of_node(int argc, char *argv[]) } } - if (optind == argc) + if (optind + 1 != argc) return COMMAND_ERROR_USAGE; - if (optind < argc) - path = argv[optind]; + path = argv[optind]; if (!path) return COMMAND_ERROR_USAGE; @@ -147,7 +146,7 @@ BAREBOX_CMD_HELP_END BAREBOX_CMD_START(of_node) .cmd = do_of_node, BAREBOX_CMD_DESC("create/delete nodes in the device tree") - BAREBOX_CMD_OPTS("[-cd] [-f] NODE NAME") + BAREBOX_CMD_OPTS("[-cd] [-f] NODEPATH") BAREBOX_CMD_GROUP(CMD_GRP_MISC) BAREBOX_CMD_COMPLETE(devicetree_complete) BAREBOX_CMD_HELP(cmd_of_node_help) -- cgit v1.2.3