From 6d4afd96fc94a3f2d256ef4e8d7c9687a145a701 Mon Sep 17 00:00:00 2001 From: Sascha Hauer Date: Tue, 28 Apr 2015 12:43:02 +0200 Subject: setenv: Be more informative when device parameter setting fails When setting a device parameter fails not only the error code is of interest, but also what the parameter name is, what the device name is and whether a device was found for this name. Add this information to the error message. Signed-off-by: Sascha Hauer --- common/env.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) (limited to 'common/env.c') diff --git a/common/env.c b/common/env.c index 2e33eb3585..c98ed73f9b 100644 --- a/common/env.c +++ b/common/env.c @@ -218,16 +218,18 @@ int setenv(const char *_name, const char *value) *par++ = 0; dev = get_device_by_name(name); - if (dev) + if (dev) { ret = dev_set_param(dev, par, value); - else + if (ret) + eprintf("%s: set parameter %s: %s\n", + dev_name(dev), par, strerror(-ret)); + } else { ret = -ENODEV; + eprintf("set parameter: no such device %s\n", name); + } errno = -ret; - if (ret < 0) - perror("set parameter"); - goto out; } -- cgit v1.2.3