From 67c1c0853fa06bcbc1725e93b6ad9942e80a1e56 Mon Sep 17 00:00:00 2001 From: Daniel Schultz Date: Thu, 12 Apr 2018 11:13:01 +0200 Subject: common: state: Add property to protect existing data After an update to a newer barebox version with an enabled state framework, existing data in storage memories could be overwritten. Add a new property to check in front of every write task, if the meta magic field only contains the magic number, zeros or ones. Signed-off-by: Daniel Schultz Signed-off-by: Sascha Hauer --- common/state/backend_bucket_direct.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'common/state/backend_bucket_direct.c') diff --git a/common/state/backend_bucket_direct.c b/common/state/backend_bucket_direct.c index 958696ed94..9d6a337e66 100644 --- a/common/state/backend_bucket_direct.c +++ b/common/state/backend_bucket_direct.c @@ -69,6 +69,8 @@ static int state_backend_bucket_direct_read(struct state_backend_storage_bucket if (meta.magic == direct_magic) { read_len = meta.written_length; } else { + if (meta.magic != ~0 && !!meta.magic) + bucket->wrong_magic = 1; if (!IS_ENABLED(CONFIG_STATE_BACKWARD_COMPATIBLE)) { dev_err(direct->dev, "No meta data header found\n"); dev_dbg(direct->dev, "Enable backward compatibility or increase stride size\n"); -- cgit v1.2.3